Add second level of --verbose to workspaces foreach to permit specifying less logging.
#6034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seansfkelley
force-pushed
the
workspaces-foreach-label
branch
from
06707fb
to
3e27931
Compare
seansfkelley
commented
Dec 22, 2023
...eptance-tests/pkg-tests-specs/sources/commands/workspaces/__snapshots__/foreach.test.js.snap
Outdated
Show resolved
Hide resolved
|
EDIT: You wrote this already, I somehow missed that. |
|
Yeah, after I wrote the implementation I realized that that could be an option:
I'm happy to change it. I don't have a preference. Do you? |
|
Heh, I missed that part of the description, my bad. Yeah, I'd prefer the multiple |
This allows specifying _less_ verbosity than the current --verbose flag, which helps avoid cluttering the output when the task being run is not expected to generate output (and we don't care about timing).
seansfkelley
force-pushed
the
workspaces-foreach-label
branch
from
3e27931
to
2ab8780
Compare
|
Alright, updated and force-pushed to rewrite out the old implementation. |
seansfkelley
changed the title
workspaces foreach to permit specifying less logging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Fixes #6033.
How did you fix it?
Changes the
-v,--verboseflag inworkspaces foreachto be a counter rather than a boolean. With one level it prints prefixes, with two levels it additionally prints start/finish/timing information (as was the behavior before).The default TTY behavior has not changed (maximum verbosity). The behavior with a single
--verbosehas changed, to be less verbose.Checklist