feat(fslib): add rmPromise
/rmSync
methods
#6226
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
The
recursive
option ofrmdir
is deprecated in Node.js. Unfortunately, because this lib doesn't expose therm
method, there's no alternative atm. This PR adds that alternative.https://nodejs.org/api/deprecations.html#DEP0147
...
How did you fix it?
I copied the
rmdir
implementations into arm
equivalent methods that calls in thefs.rm
instead offs.rmdir
....
Checklist