Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for user-defined wrappers in the SDK #6370

Merged
merged 4 commits into from
Jul 29, 2024
Merged

Conversation

arcanis
Copy link
Member

@arcanis arcanis commented Jul 2, 2024

What's the problem this PR addresses?

At work we're patching the SDK files to also send monitoring information to our servers (so we can know how much time TS takes to run within VSCode). This makes updating the SDK a little difficult, as we need to remember to re-add the patched code after each update.

How did you fix it?

The SDK will now automatically require the optional user.sdk.cjs file if present, which must be located next to the file to patch.

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@arcanis arcanis merged commit d463ea4 into master Jul 29, 2024
22 of 26 checks passed
@arcanis arcanis deleted the mael/user-wrap branch July 29, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant