Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify release title #1682

Closed
volodya-lombrozo opened this issue Apr 13, 2023 · 4 comments · Fixed by #1694
Closed

Specify release title #1682

volodya-lombrozo opened this issue Apr 13, 2023 · 4 comments · Fixed by #1694

Comments

@volodya-lombrozo
Copy link
Contributor

As far as I know, when Rultor creates a release, the release has a name of the last commit, for example like:

It's not so beautiful and I have to search for the tag that was attached to that release, I believe it would be better to give more meaningful name to a release, for example:

  • "Version 1.6.4"
  • Or just "1.6.4"

Also we can allow to pass the custom release name in rultor command:

@rultor please, release, tag is '0.1.2' and title 'Awesome Version 0.1.2'
@volodya-lombrozo
Copy link
Contributor Author

@yegor256 What do you think?

@yegor256
Copy link
Owner

@volodya-lombrozo I like this one:

@rultor release tag is `0.0.0` and title is `hello, world`

@volodya-lombrozo
Copy link
Contributor Author

@yegor256 What about the default behaviour? Do you want to leave it as is (== "the last commit message")?

@yegor256
Copy link
Owner

@volodya-lombrozo yes, it would be most logical, since there could be users who expect this behavior

volodya-lombrozo added a commit to volodya-lombrozo/rultor that referenced this issue May 13, 2023
volodya-lombrozo added a commit to volodya-lombrozo/rultor that referenced this issue May 13, 2023
volodya-lombrozo added a commit to volodya-lombrozo/rultor that referenced this issue May 13, 2023
volodya-lombrozo added a commit to volodya-lombrozo/rultor that referenced this issue May 13, 2023
volodya-lombrozo added a commit to volodya-lombrozo/rultor that referenced this issue May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants