Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for worker #123

Merged
merged 3 commits into from
Jun 17, 2022
Merged

Add test for worker #123

merged 3 commits into from
Jun 17, 2022

Conversation

romkatsu
Copy link
Member

@romkatsu romkatsu commented Jun 6, 2022

Q A
Is bugfix? ❌
New feature? ❌
Breaks BC? ❌
Fixed issues #27

@romkatsu romkatsu requested review from viktorprogger and a team June 6, 2022 16:59
@romkatsu romkatsu added type:test Test status:code review The pull request needs review. labels Jun 6, 2022
viktorprogger
viktorprogger approved these changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@viktorprogger viktorprogger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to move these tests from unit to integrational, everything other LGTM

@romkatsu romkatsu merged commit f10b2f3 into yiisoft:master Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viktorprogger viktorprogger viktorprogger approved these changes

Assignees
No one assigned
Labels
status:code review The pull request needs review. type:test Test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romkatsu @viktorprogger