Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more tests and allow partly run #49

Merged
merged 33 commits into from
Sep 21, 2020
Merged

Add more tests and allow partly run #49

merged 33 commits into from
Sep 21, 2020

Conversation

viktorprogger
Copy link
Contributor

@viktorprogger viktorprogger commented Jul 8, 2020 •
edited
Loading

Q A
Is bugfix? ❌
New feature? ✔️
Breaks BC? ❌
Fixed issues #27

@viktorprogger viktorprogger requested review from samdark and a team July 8, 2020 13:14
xepozz
xepozz reviewed Jul 8, 2020
View reviewed changes
Copy link
Member

@xepozz xepozz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tests 👍

tests/unit/CallableJobTest.php Outdated Show resolved Hide resolved
src/Queue.php Show resolved Hide resolved
tests/unit/ExceptionTest.php Outdated Show resolved Hide resolved
@xepozz
Copy link
Member

xepozz commented Jul 8, 2020

Fixed issues #46

Incorrect issue specified

@viktorprogger
Copy link
Contributor Author

@xepozz thank you for your comments

@samdark
Copy link
Member

samdark commented Jul 10, 2020

Overall looks fine so far.

@viktorprogger viktorprogger added the status:under development Someone is working on a pull request. label Jul 23, 2020
viktorprogger and others added 19 commits August 3, 2020 12:05
@viktorprogger viktorprogger added status:code review The pull request needs review. and removed status:under development Someone is working on a pull request. labels Sep 16, 2020
@viktorprogger viktorprogger marked this pull request as ready for review September 16, 2020 11:42
@viktorprogger viktorprogger requested a review from a team September 16, 2020 11:46
@roxblnfk
Copy link
Member

infection.log should be ignored

@viktorprogger viktorprogger added this to the 3.0.0-alpha1 milestone Sep 18, 2020
@samdark samdark merged commit 3f557f0 into master Sep 21, 2020
@samdark samdark deleted the tests branch September 21, 2020 21:42
@samdark
Copy link
Member

samdark commented Sep 21, 2020

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark samdark approved these changes

@xepozz xepozz Awaiting requested review from xepozz

@romkatsu romkatsu Awaiting requested review from romkatsu

Assignees
No one assigned
Labels
status:code review The pull request needs review.
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@viktorprogger @xepozz @samdark @roxblnfk @romkatsu