Skip to content

Commit

Permalink
UCT/MM: Fix endpoint flush - don't update cached tail
Browse files Browse the repository at this point in the history
We must not update cached tail in uct_mm_ep_flush(), because we don't
execute the pending queue. As a result, we may get new send resources
but not use them, so flush could return UCS_OK while there are still
pending requests.

Fixes openucx#3052
  • Loading branch information
yosefe committed Nov 22, 2018
1 parent 0e3fcd4 commit 0924607
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/uct/sm/mm/mm_ep.c
Original file line number Diff line number Diff line change
Expand Up @@ -417,8 +417,6 @@ ucs_status_t uct_mm_ep_flush(uct_ep_h tl_ep, unsigned flags,
{
uct_mm_ep_t *ep = ucs_derived_of(tl_ep, uct_mm_ep_t);

uct_mm_ep_update_cached_tail(ep);

if (!uct_mm_ep_has_tx_resources(ep)) {
return UCS_ERR_NO_RESOURCE;
}
Expand Down

0 comments on commit 0924607

Please sign in to comment.