UCS/CONFIG: let ucx support configuration file #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-dubman
reviewed
Dec 3, 2020
| @@ -1134,9 +1179,13 @@ static ucs_status_t ucs_config_apply_env_vars(void *opts, ucs_config_field_t *fi | |||
| } else { | |||
| /* Read and parse environment variable */ | |||
| strncpy(buf + prefix_len, field->name, sizeof(buf) - prefix_len - 1); | |||
| /* environmental variavle prior to file config */ | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
let ucx support configuration file
Why
Now we can use environment variable to set the configuration of UCX. Environment variable maybe not meet expectation if in a complex environmet. So I provide another way to set UCX configuration.
How
I use inih to read configuration file, which is BSD-3.
the prioirty of configuration: environment variable > config file > default.