UCT/IB/BASE: use random roce path factor to achieve high reliability. #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yosefe
reviewed
Mar 8, 2021
leibin2014
force-pushed
the
integration3
branch
2 times, most recently
from
622a827
to
40521c7
Compare
yosefe
reviewed
May 12, 2021
src/uct/ib/base/ib_iface.c
Outdated
Comment on lines
536
to
537
| udp_sport = iface->config.roce_path_factor * path_index; | ||
| if (iface->config.en_random_factor) { |
src/uct/ib/base/ib_iface.c
Outdated
| udp_sport = iface->config.roce_path_factor * path_index; | ||
| udp_sport = iface->config.roce_path_factor * path_index; | ||
| if (iface->config.en_random_factor) { | ||
| assert(iface->config.roce_path_factor <= UCT_IB_ROCE_MAX_PATH_FACTOR); |
There was a problem hiding this comment.
@yosefe Already applied this comment:
#127 (comment)
yosefe
approved these changes
May 12, 2021
@yosefe Done. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UCT/IB/BASE: use random roce path factor to achieve high reliability.
When the switches on the current path have problem, the application can disconnect and reconnect again to achieve high reliability. A random roce path factor will be generated to find different sport and use different path.