Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UCS/MEMTRACK: added public API for memtrack - int3 #158

Merged

Conversation

hoopoepg
Copy link

@hoopoepg hoopoepg commented Jul 9, 2021

  • routines ucs_memtrack_allocated and ucs_memtrack_releasing moved
    to public header
  • added internal memtrack header
  • memtrack configure option is removed, memtrack
    now is always built-in
  • removed --enable-memtrack params

back port from openucx#7032

pthread_mutex_unlock(&ucs_memtrack_context.lock);
}

static UCS_F_ALWAYS_INLINE void ucs_memtrack_releasing_internal(void *ptr)
{
if (!ucs_memtrack_is_enabled()) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in master branch, ucs_malloc and co. code was changed to call ucs_memtrack_allocated_internal

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, fixed

Copy link
Owner

@yosefe yosefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls squash

- routines ucs_memtrack_allocated and ucs_memtrack_releasing moved
  to public header
- added internal memtrack header
- memtrack configure option is removed, memtrack
  now is always built-in
- removed --enable-memtrack params
@hoopoepg hoopoepg force-pushed the topic/make-memtrack-api-public-int3 branch from 0719c25 to de3247c Compare July 13, 2021 12:40
@yosefe yosefe merged commit d8c5e65 into yosefe:integration3 Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants