UCP/EP/CLOSE: discard ep_close(FLUSH) mode #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- due to lack of support close protocol have to discard ep_close(FLUSH) mode, use ep_close(FORCE) instead - removed flush(LOCAL) call from CM disconnect event due to request leak
yosefe
reviewed
Sep 2, 2021
| @@ -534,7 +445,6 @@ static unsigned ucp_ep_cm_disconnect_progress(void *arg) | |||
| ucs_assert(!(ucp_ep->flags & UCP_EP_FLAG_CLOSE_REQ_VALID)); | |||
| } else if (ucp_ep->flags & UCP_EP_FLAG_LOCAL_CONNECTED) { | |||
| /* if the EP is local connected, need to flush it from main thread first */ | |||
| ucp_ep_cm_remote_disconnect_progress(ucp_ep); | |||
There was a problem hiding this comment.
do we need to call ucp_ep_cm_disconnect_cm_lane() as if flush is completed?
@evgeny-leksikov wdyt?
There was a problem hiding this comment.
I don't think so, because the only thing which is allowed and mandatory after err callback - close the EP (and only forced starting from this PR)
There was a problem hiding this comment.
so we rely on use to close the ep (from err callback) which will call ucp_ep_cm_disconnect_cm_lane?
There was a problem hiding this comment.
yes, actually it does not matter disconnect or close CM lane
evgeny-leksikov
approved these changes
Sep 2, 2021
yosefe
approved these changes
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ep_close(FLUSH) mode, use ep_close(FORCE) instead
request leak