Set modify-QP global address parameters only for GRH case #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Back port PR: openucx#6061 |
|
@ybedbug, please help confirm this PR is needed for connection under IB. |
|
@changchengx I think this is needed under IB. Just because my test is for client/server in same subnet, the GRH which these config should be set on did not exist. If for other cases under IB i.e. sending packets to another subnet/multicast group, is_global would not be 0 and the GRH would be there and these config can be set in GRH. |
|
@ybedbug Thanks for your confirmation. |
|
@yosefe Could you also trigger CI test on this PR? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1. Back-port master/RP/6061 to integration3 branch
2. This is required by "address path structure fields"
1) hop_limit:
For IB and RoCE version 1.0: GRH Hop Limit.
2) rgid_or_rip:
For IB port - Valid if the GRH bit is set.
For an Ethernet port for RoCE mode, this field must always be valid and
contain the remote GID address.
3) traffic class:
For InfiniBand and RoCE v1.0: GRH TClass
3. According to IB Spec:
1) Address vector, for UD transports only, containing:
For global destination:
• Flow label.
• Hop limit.
• Traffic class.
• Source GID index.
2) Address vector, for RC & UC transports only, containing:
For global destination:
• Traffic class.
• Flow label.
• Hop limit.
• Source GID index.
• Destination’s GID.
Signed-off-by: Changcheng Liu <jerrliu@nvidia.com>
changchengx
force-pushed
the
addr_param_grh
branch
2 times, most recently
from
323e8bd
to
fa0889a
Compare
Signed-off-by: Changcheng Liu <jerrliu@nvidia.com>
changchengx
force-pushed
the
addr_param_grh
branch
from
fa0889a
to
85bdac2
Compare
|
@yosefe Do we have plan to merge this PR? It's ported from openucx#6061 |
yosefe
reviewed
Apr 6, 2022
| UCT_IB_MLX5DV_SET(qpc, qpc, primary_address_path.tclass, | ||
| iface->super.super.config.traffic_class); | ||
|
|
||
| if (ah_attr->is_global) { |
| /* TODO add flow_label support */ | ||
| UCT_IB_MLX5DV_SET(qpc, qpc, primary_address_path.tclass, | ||
| iface->super.super.config.traffic_class); | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.