UCP/TAG/RNDV: Complete send operation only if RTS wasn't sent #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
currently, it successfully passed 15 iterations of the reproducer from the link specified in the description. |
|
@evgeny-leksikov @hoopoepg could you review pls? |
hoopoepg
approved these changes
Dec 23, 2021
evgeny-leksikov
approved these changes
Dec 23, 2021
src/ucp/tag/rndv.c
Outdated
Comment on lines
422
to
423
| if (!(sreq->send.ep->flags & UCP_EP_FLAG_REMOTE_CONNECTED)) { | ||
| if (sreq->flags & UCP_REQUEST_FLAG_RNDV_RTS_SENT) { | ||
| if (!(sreq->flags & UCP_REQUEST_FLAG_RNDV_RTS_SENT)) { |
There was a problem hiding this comment.
minor: maybe invert if/else? positive conditions are simpler for reading
dmitrygx
force-pushed
the
topic/ucp/rndv_complete_rts_int3
branch
from
5c062a1
to
97be7b6
Compare
evgeny-leksikov
approved these changes
Dec 23, 2021
yosefe
approved these changes
Jan 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
http://hpcweb.lab.mtl.com/hpc/mtr_scrap/users/mtt/scratch/ucx_ompi/20211220_211114_26976_84801_jazz07.swx.labs.mlnx/html/test_stdout_w5cd6S.txt
UCP RNDV request should be completed during the request cancellation procedure only if the RTS packet wasn't sent to the peer (i.e. the peer is not aware of this operation). If the RTS packet was sent we should put the request on the list of canceled requests and it will be cleaned when all UCT lanes are destroyed and UCP EP is under destroying.