UCT/IB: complete RX CQ cleanup on device failure #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrygx
approved these changes
Dec 23, 2021
yosefe
reviewed
Jan 1, 2022
src/uct/ib/base/ib_device.c
Outdated
| @@ -298,6 +298,10 @@ static void uct_ib_async_event_handler(int fd, void *arg) | |||
| level = UCS_LOG_LEVEL_DEBUG; | |||
| break; | |||
| case IBV_EVENT_DEVICE_FATAL: | |||
| ucs_assert(event.element.port_num == 0); | |||
There was a problem hiding this comment.
why needed?
maybe just pass 0 instead of event.element.port_num?
evgeny-leksikov
force-pushed
the
integration3
branch
from
6f32ff2
to
984f799
Compare
ok |
yosefe
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix a stuck on CQ resources cleanup in case of device fatal error