UCM/BISTRO: Use relative jump instead of absolute jump #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When patching glibc() functions for memory hooks, try to use relative jump instruction if the hook is within 32 bit offset of the original function. This way the patch can be 5 bytes instead of 13 bytes, and avoid race with another thread executing the patched function.
|
@hoopoepg can you pls review (for int3 branch)? |
hoopoepg
approved these changes
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When patching glibc() functions for memory hooks, try to use relative
jump instruction if the hook is within 32 bit offset of the original
function. This way the patch can be 5 bytes instead of 13 bytes, and
avoid race with another thread executing the patched function.