Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement methods for EzyWSClient #34

Merged
merged 3 commits into from
Aug 6, 2023
Merged

implement methods for EzyWSClient #34

merged 3 commits into from
Aug 6, 2023

Conversation

vu-luong
Copy link
Member

@vu-luong vu-luong commented Aug 6, 2023

No description provided.

@vu-luong vu-luong requested a review from tvd12 August 6, 2023 00:57
tvd12
tvd12 reviewed Aug 6, 2023
View reviewed changes
unity/EzyWSClient.cs Outdated

public byte[] getPublicKey()
{
throw new NotImplementedException();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

throw new InvalidOperationException("not supported");

tvd12
tvd12 reviewed Aug 6, 2023
View reviewed changes
unity/EzyWSClient.cs Outdated

public void setPublicKey(byte[] publicKey)
{
throw new NotImplementedException();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

throw new InvalidOperationException("not supported");

tvd12
tvd12 reviewed Aug 6, 2023
View reviewed changes
unity/EzyWSClient.cs Outdated

public byte[] getPrivateKey()
{
throw new NotImplementedException();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

throw new InvalidOperationException("not supported");

tvd12
tvd12 reviewed Aug 6, 2023
View reviewed changes
unity/EzyWSClient.cs Outdated

public void setPrivateKey(byte[] privateKey)
{
throw new NotImplementedException();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

throw new InvalidOperationException("not supported");

tvd12
tvd12 reviewed Aug 6, 2023
View reviewed changes
unity/EzyWSClient.cs Outdated

public byte[] getSessionKey()
{
throw new NotImplementedException();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

throw new InvalidOperationException("not supported");

tvd12
tvd12 reviewed Aug 6, 2023
View reviewed changes
unity/EzyWSClient.cs Outdated

public void setSessionKey(byte[] sessionKey)
{
throw new NotImplementedException();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

throw new InvalidOperationException("not supported");

tvd12
tvd12 reviewed Aug 6, 2023
View reviewed changes
unity/EzyWSClient.cs Outdated
@@ -248,6 +273,16 @@ public EzyClientConfig getConfig()
return this.config;
}

public bool isEnableSSL()
{
return this.config.isEnableSSL();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

throw new InvalidOperationException("not supported");

tvd12
tvd12 reviewed Aug 6, 2023
View reviewed changes
unity/EzyWSClient.cs Outdated
@@ -228,6 +243,16 @@ public void udpConnect(string host, int port)
throw new NotImplementedException();
}

public void udpSend(EzyRequest request, bool encrypted = false)
{
throw new NotImplementedException();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

throw new InvalidOperationException("not supported");

tvd12
tvd12 reviewed Aug 6, 2023
View reviewed changes
unity/EzyWSClient.cs Outdated

public void udpSend(EzyCommand cmd, EzyArray data, bool encrypted = false)
{
throw new NotImplementedException();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

throw new InvalidOperationException("not supported");

tvd12
tvd12 requested changes Aug 6, 2023
View reviewed changes
Copy link
Member

@tvd12 tvd12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PLTAL

@vu-luong vu-luong requested a review from tvd12 August 6, 2023 01:16
tvd12
tvd12 approved these changes Aug 6, 2023
View reviewed changes
Copy link
Member

@tvd12 tvd12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tvd12
tvd12 reviewed Aug 6, 2023
View reviewed changes
unity/EzyWSClient.cs Outdated
@@ -248,6 +273,16 @@ public EzyClientConfig getConfig()
return this.config;
}

public bool isEnableSSL()
{
throw new InvalidOperationException("not supported");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return false

tvd12
tvd12 approved these changes Aug 6, 2023
View reviewed changes
Copy link
Member

@tvd12 tvd12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvd12 tvd12 merged commit 602c5c5 into unity-client Aug 6, 2023
@tvd12 tvd12 deleted the unity-fix-websocket-client branch August 6, 2023 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvd12 tvd12 tvd12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vu-luong @tvd12