Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge master #49

Merged
merged 7 commits into from
Oct 29, 2023
Merged

Merge master #49

merged 7 commits into from
Oct 29, 2023

Conversation

tvd12
Copy link
Member

@tvd12 tvd12 commented Oct 18, 2023

No description provided.

vu-luong and others added 3 commits September 29, 2023 21:11
@vu-luong
add virtual to ping schedule methods (#45)
89c6beb
@tvd12
add event loop group (#42)
534e73d 
* add event loop group

* usage

* update

* update

* update

* set eventLoopGroup for udp client

* remove empy line

* remove empy line

* correct to use delayTime
@tvd12
fix conflict
29a28ec
@tvd12 tvd12 requested a review from vu-luong October 18, 2023 13:04
@vu-luong
Copy link
Member

There is error in EzyWSPingSchedule constructor, I think we'd have to update

		public EzyWSPingSchedule(EzyClient client) : base(client)
		{
		}

to

		public EzyWSPingSchedule(EzyClient client) : base(client, null)
		{
		}

vu-luong
vu-luong approved these changes Oct 29, 2023
View reviewed changes
Copy link
Member

@vu-luong vu-luong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vu-luong vu-luong merged commit 911675b into unity-client Oct 29, 2023
@tvd12 tvd12 deleted the merge-master branch October 30, 2023 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vu-luong vu-luong vu-luong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tvd12 @vu-luong