Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

standard ssl implementation #110

Merged
merged 50 commits into from
Oct 15, 2023
Merged

standard ssl implementation #110

merged 50 commits into from
Oct 15, 2023

Conversation

tvd12
Copy link
Member

@tvd12 tvd12 commented Jul 10, 2023 •
edited
Loading

  • Add ssl handshake handler
  • Add ssl data reader
  • Add ssl data writer
  • Add ssl handshake handler unit test: Doing
  • Add ssl data reader unit test
  • Add ssl data writer unit test
  • Integration test localhost
  • Integration test remote server
  • Set max package size

anaconda875
anaconda875 reviewed Jul 14, 2023
View reviewed changes
ezyfox-server-core/settings/ssl/ssl-key-store.txt Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should not name the keystore extension as .txt. If it is java keystore format, just name it .jks. Correct me if im wrong

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you're right, but it's just an example, you can specific your keystore file via: https://github.com/youngmonkeys/ezyfox-server/blob/master/ezyfox-server-core/settings/ssl-config.properties#L1

@tvd12 tvd12 added the 3 label Aug 20, 2023
@tvd12 tvd12 requested a review from vu-luong August 25, 2023 03:57
vu-luong
vu-luong approved these changes Oct 15, 2023
View reviewed changes
Copy link
Member

@vu-luong vu-luong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vu-luong vu-luong merged commit 06c0331 into master Oct 15, 2023
1 check passed
@tvd12 tvd12 deleted the ssl branch October 15, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anaconda875 anaconda875 anaconda875 left review comments

@vu-luong vu-luong vu-luong approved these changes

Assignees
No one assigned
Labels
3 feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tvd12 @vu-luong @anaconda875