Add Screen to replace cli::Runner #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cli::Runner` is a bit difficult to update for adding new features, so I want to replace it with the new implementation, `Screen`. `Screen` will behave like `cli::Runner`, but it's written for extensibility. Still, this struct is huge, but I believe it's better than `cli::Runner`. This patch just adds `Screen`. I will replace `cli::Runner` with it later.
yykamei
added a commit
that referenced
this pull request
Aug 15, 2024
With #1040, `Screen` can be available in this project. This patch replaces `cli::Runner` with `Screen`. Note this patch also includes changes on the `tests/` directory because tests will fail with this replacement. I'm considering refining the tests with more readable and robust way.
yykamei
added a commit
that referenced
this pull request
Aug 15, 2024
With #1040, `Screen` can be available in this project. This patch replaces `cli::Runner` with `Screen`. Note this patch also includes changes on the `tests/` directory because tests will fail with this replacement. I'm considering refining the tests with more readable and robust way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cli::Runneris a bit difficult to update for adding new features, so I want to replace it with the new implementation,Screen.Screenwill behave likecli::Runner, but it's written for extensibility. Still, this struct is huge, but I believe it's better thancli::Runner.This patch just adds
Screen. I will replacecli::Runnerwith it later.