fix: correct modal rendering on Webkit (#466)

zakodium-oss · Mar 24, 2023 · 46ed4de · 46ed4de
1 parent 60b0eed
commit 46ed4de
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 19 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -67,12 +67,12 @@
     "@lukeed/uuid": "^2.0.0",
     "@popperjs/core": "^2.11.6",
     "@tanstack/react-query": "^4.28.0",
-    "@tanstack/react-table": "^8.7.9",
+    "@tanstack/react-table": "^8.8.0",
     "biologic-converter": "^0.6.0",
     "cheminfo-types": "^1.4.0",
     "d3-scale-chromatic": "^3.0.0",
     "filelist-utils": "^1.8.0",
-    "immer": "^9.0.19",
+    "immer": "^9.0.21",
     "jcampconverter": "^9.1.0",
     "lodash": "^4.17.21",
     "ml-gsd": "^12.1.2",

diff --git a/src/components/modal/ConfirmModal.tsx b/src/components/modal/ConfirmModal.tsx
@@ -21,7 +21,6 @@ interface ConfirmModalProps {
 }
 
 const ConfirmModalDialog = styled.dialog`
-  position: fixed;
   background-color: transparent;
 
   ::backdrop {
@@ -36,7 +35,6 @@ const ConfirmModalContents = styled.div<{
   display: flex;
   flex-direction: column;
   background-color: white;
-  max-height: 90%;
   width: 100%;
   border-width: 1px;
   border-color: transparent;

diff --git a/src/components/modal/Modal.tsx b/src/components/modal/Modal.tsx
@@ -19,7 +19,6 @@ export interface ModalProps {
 }
 
 const DialogRoot = styled.dialog`
-  position: fixed;
   background-color: transparent;
 
   ::backdrop {
@@ -32,7 +31,6 @@ const DialogContents = styled.div`
   display: flex;
   flex-direction: column;
   background-color: white;
-  max-height: 90%;
   border-width: 1px;
   border-color: transparent;
   border-radius: 0.5rem;