fix: add shasum flag and test for https pull #2998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
❌ Deploy Preview for zarf-docs failed. Why did it fail? →
|
Codecov ReportAttention: Patch coverage is
|
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
phillebaba
reviewed
Sep 16, 2024
phillebaba
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the
zarf package pull <https-url>has no shasum flag, since we recently removed the insecure functionality in #2936 this means it's impossible to pull a package with an https url on main. This PR adds the shasum flag as well as a test.Related Issue
Fixes #2999
Checklist before merging