Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: create #3005

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: create #3005

wants to merge 1 commit into from
+125 −19

Conversation

phillebaba
Copy link
Member

Description

Refactors create command.

Related Issue

Relates to #2969

Checklist before merging

@phillebaba
refactor: create
bd99df4 
Signed-off-by: Philip Laine <philip.laine@gmail.com>
@netlify Netlify
Copy link

netlify bot commented Sep 17, 2024 •
edited
Loading

✅ Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit bd99df4
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/66e9ddbe57c69c0008c70567

@codecov Codecov
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 58 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/internal/packager2/create.go 0.00% 56 Missing ⚠️
src/cmd/package.go 0.00% 2 Missing ⚠️
Files with missing lines Coverage Δ
src/cmd/package.go 0.00% <0.00%> (ø)
src/internal/packager2/create.go 0.00% <0.00%> (ø)

@phillebaba phillebaba marked this pull request as ready for review September 18, 2024 15:46
@phillebaba phillebaba requested review from a team as code owners September 18, 2024 15:46
schristoff
schristoff reviewed Sep 18, 2024
View reviewed changes
src/internal/packager2/create.go
"github.com/zarf-dev/zarf/src/pkg/utils"
"github.com/zarf-dev/zarf/src/types"
)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CreateOpts should go here, no?

AustinAbro321
AustinAbro321 approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@AustinAbro321 AustinAbro321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, would love to see createOpts no longer passed into the package creator interface. But that should definitely be separate from this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schristoff schristoff schristoff left review comments

@AustinAbro321 AustinAbro321 AustinAbro321 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phillebaba @schristoff @AustinAbro321