Skip to content

Commit

Permalink
boards: qemu_x86: disable QEMU icount with shell and HPET timer
Browse files Browse the repository at this point in the history
For some unknown reasons, using the new modified HPET timer would
render shell unresponsive under QEMU. So for now, disable QEMU
icount when shell is enabled.

Fixes #37672

Signed-off-by: Daniel Leung <daniel.leung@intel.com>
  • Loading branch information
dcpleung authored and nashif committed Sep 15, 2021
1 parent 6de4747 commit cd5357c
Show file tree
Hide file tree
Showing 9 changed files with 18 additions and 8 deletions.
18 changes: 18 additions & 0 deletions boards/x86/qemu_x86/Kconfig.defconfig
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,12 @@ config MULTIBOOT_INFO
config MULTIBOOT_MEMMAP
default y if MULTIBOOT

config QEMU_ICOUNT
default n if HPET_TIMER && SHELL

config QEMU_ICOUNT_SHIFT
default 5

endif # BOARD_QEMU_X86

if BOARD_QEMU_X86_64
Expand Down Expand Up @@ -55,6 +61,12 @@ config X86_PC_COMPATIBLE
# QEMU presents a PC-compatible machine
default y

config QEMU_ICOUNT
default n if HPET_TIMER && SHELL

config QEMU_ICOUNT_SHIFT
default 5

endif # BOARD_QEMU_X86_LAKEMONT

if BOARD_QEMU_X86_TINY
Expand All @@ -76,6 +88,12 @@ config X86_PC_COMPATIBLE
# QEMU presents a PC-compatible machine
default y

config QEMU_ICOUNT
default n if HPET_TIMER && SHELL

config QEMU_ICOUNT_SHIFT
default 5

config HAVE_CUSTOM_LINKER_SCRIPT
default y

Expand Down
1 change: 0 additions & 1 deletion boards/x86/qemu_x86/qemu_x86_defconfig
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,3 @@ CONFIG_DEBUG_INFO=y
CONFIG_SCHED_SCALABLE=y
CONFIG_WAITQ_SCALABLE=y
CONFIG_X86_VERY_EARLY_CONSOLE=y
CONFIG_QEMU_ICOUNT_SHIFT=5
1 change: 0 additions & 1 deletion boards/x86/qemu_x86/qemu_x86_lakemont_defconfig
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,3 @@ CONFIG_DEBUG_INFO=y
CONFIG_SCHED_SCALABLE=y
CONFIG_WAITQ_SCALABLE=y
CONFIG_X86_VERY_EARLY_CONSOLE=y
CONFIG_QEMU_ICOUNT_SHIFT=5
1 change: 0 additions & 1 deletion boards/x86/qemu_x86/qemu_x86_nokpti_defconfig
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,4 @@ CONFIG_DEBUG_INFO=y
CONFIG_SCHED_SCALABLE=y
CONFIG_WAITQ_SCALABLE=y
CONFIG_X86_VERY_EARLY_CONSOLE=y
CONFIG_QEMU_ICOUNT_SHIFT=5
CONFIG_X86_KPTI=n
1 change: 0 additions & 1 deletion boards/x86/qemu_x86/qemu_x86_nommu_defconfig
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,3 @@ CONFIG_UART_CONSOLE=y
CONFIG_SYS_CLOCK_HW_CYCLES_PER_SEC=25000000
CONFIG_TEST_RANDOM_GENERATOR=y
CONFIG_DEBUG_INFO=y
CONFIG_QEMU_ICOUNT_SHIFT=5
1 change: 0 additions & 1 deletion boards/x86/qemu_x86/qemu_x86_nopae_defconfig
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,4 @@ CONFIG_DEBUG_INFO=y
CONFIG_SCHED_SCALABLE=y
CONFIG_WAITQ_SCALABLE=y
CONFIG_X86_VERY_EARLY_CONSOLE=y
CONFIG_QEMU_ICOUNT_SHIFT=5
CONFIG_X86_PAE=n
1 change: 0 additions & 1 deletion boards/x86/qemu_x86/qemu_x86_tiny_defconfig
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ CONFIG_DEBUG_INFO=y
CONFIG_SCHED_SCALABLE=y
CONFIG_WAITQ_SCALABLE=y
CONFIG_X86_VERY_EARLY_CONSOLE=y
CONFIG_QEMU_ICOUNT_SHIFT=5

CONFIG_X86_PAE=n
CONFIG_X86_COMMON_PAGE_TABLE=y
Expand Down
1 change: 0 additions & 1 deletion boards/x86/qemu_x86/qemu_x86_virt_defconfig
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ CONFIG_DEBUG_INFO=y
CONFIG_SCHED_SCALABLE=y
CONFIG_WAITQ_SCALABLE=y
CONFIG_X86_VERY_EARLY_CONSOLE=y
CONFIG_QEMU_ICOUNT_SHIFT=5

CONFIG_SRAM_OFFSET=0x100000
CONFIG_KERNEL_VM_SIZE=0x400000
Expand Down
1 change: 0 additions & 1 deletion boards/x86/qemu_x86/qemu_x86_xip_defconfig
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,4 @@ CONFIG_DEBUG_INFO=y
CONFIG_SCHED_SCALABLE=y
CONFIG_WAITQ_SCALABLE=y
CONFIG_X86_VERY_EARLY_CONSOLE=y
CONFIG_QEMU_ICOUNT_SHIFT=5
CONFIG_XIP=y

0 comments on commit cd5357c

Please sign in to comment.