Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samples/philosophers/sample.kernel.philosopher.stacks fails on xtensa #38405

Closed
galak opened this issue Sep 9, 2021 · 0 comments · Fixed by #38429
Closed

samples/philosophers/sample.kernel.philosopher.stacks fails on xtensa #38405

galak opened this issue Sep 9, 2021 · 0 comments · Fixed by #38429
Assignees
@dcpleung
Labels
area: Xtensa Xtensa Architecture bug The issue is a bug, or the PR is fixing a bug priority: high High impact/importance bug

Comments

@galak
Copy link
Collaborator

galak commented Sep 9, 2021

./scripts/twister -s samples/philosophers/sample.kernel.philosopher.stacks -a xtensa -l

Gets:

ERROR   - qemu_xtensa               samples/philosophers/sample.kernel.philosopher.stacks FAILED: Build failure
ERROR   - see: /home/galak/git/zephyr/twister-out/qemu_xtensa/samples/philosophers/sample.kernel.philosopher.stacks/build.log
INFO    - Total complete:    1/   3  33%  skipped:    8, failed:    1
ERROR   - intel_s1000_crb           samples/philosophers/sample.kernel.philosopher.stacks FAILED: Build failure
ERROR   - see: /home/galak/git/zephyr/twister-out/intel_s1000_crb/samples/philosophers/sample.kernel.philosopher.stacks/build.log

Log has:

/home/galak/git/zephyr/subsys/debug/thread_info.c:87:2: error: #warning Please define THREAD_INFO_OFFSET_T_STACK_PTR for this architecture [-Werror=cpp]
   87 | #warning Please define THREAD_INFO_OFFSET_T_STACK_PTR for this architecture
      |  ^~~~~~~
cc1: all warnings being treated as errors
@galak galak added the bug The issue is a bug, or the PR is fixing a bug label Sep 9, 2021
@galak galak added area: Xtensa Xtensa Architecture priority: high High impact/importance bug labels Sep 9, 2021
dcpleung added a commit to dcpleung/zephyr that referenced this issue Sep 9, 2021
@dcpleung
debug: thread_info: stack pointer is not supported for xtensa
80a06c7 
Xtensa does not store the stack pointers in thread objects but
pushing the registers into the stack. There is no fixed location
to retrieve the stack pointer so mark it as unimplemented to
avoid the #warning.

Fixes zephyrproject-rtos#38405

Signed-off-by: Daniel Leung <daniel.leung@intel.com>
@dcpleung dcpleung linked a pull request Sep 9, 2021 that will close this issue
samples: philosophers: fix Xtensa and pointer type mismatch warnings #38429
Merged
cfriedt pushed a commit that referenced this issue Sep 9, 2021
@dcpleung @cfriedt
debug: thread_info: stack pointer is not supported for xtensa
1672f6c 
Xtensa does not store the stack pointers in thread objects but
pushing the registers into the stack. There is no fixed location
to retrieve the stack pointer so mark it as unimplemented to
avoid the #warning.

Fixes #38405

Signed-off-by: Daniel Leung <daniel.leung@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dcpleung dcpleung

Labels
area: Xtensa Xtensa Architecture bug The issue is a bug, or the PR is fixing a bug priority: high High impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

samples: philosophers: fix Xtensa and pointer type mismatch warnings dcpleung/zephyr
2 participants
@galak @dcpleung