-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lwm2m: report acknowledgement of notifications to app #38531
Comments
I think that a reasonable approach would be to replace
The question rises whether this should be handled by a separate callback. or rather to extend the existing list of events, but IMO it'd make sense to separate the observe related-stuff from the registration related events, monitoring such events would be optional then for interested parties only. |
I think a key thing here is to allow the application to track notifications from creation to acknowledge or timeout via this generic lwm2m_observe_cb_t |
I like the idea.
I don't quite understand this. E.g. the path is available at the time the acknowledgement is received. Or are you saying this information should be withheld intentionally, to "force" the app to keep track of the precise notification/ack pair if it want's to know what was acknowledged? |
When an acknowledge is received it refers to the token. You can perhaps look up the token to see what path it corresponds to, but if you want to go to sleep you will have to ensure that the latest notification is acknowledged, that is, track each notification to acknowledge or timeout. It's not enough to know the path if you have the potential for multiple notifications from that path. |
If everyone is okay with it, I would like to pick this up in light of #32610 . |
For everyone interested:
|
Added an observe callback so that the application can register to receive events like observer added/deleted, and notification acked/ timed out. The notifications can be traced back to the exact data contained within them by use of the user_data pointer. Fixes zephyrproject-rtos#38531. Signed-off-by: Maik Vermeulen <maik.vermeulen@innotractor.com>
Added an observe callback so that the application can register to receive events like observer added/deleted, and notification acked/ timed out. The notifications can be traced back to the exact data contained within them by use of the user_data pointer. Fixes zephyrproject-rtos#38531. Signed-off-by: Maik Vermeulen <maik.vermeulen@innotractor.com>
Added an observe callback so that the application can register to receive events like observer added/deleted, and notification acked/ timed out. The notifications can be traced back to the exact data contained within them by use of the user_data pointer. Fixes #38531. Signed-off-by: Maik Vermeulen <maik.vermeulen@innotractor.com>
Right now the application has no way of knowing whether the server has received data. PR #36453 added a callback to inform the application of timeouts, but it doesn't trigger on successfull delivery/acknowledgement.
I believe there are (at least) two valid use cases for this:
The text was updated successfully, but these errors were encountered: