Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/lib/cmsis_dsp: malloc failed on 128K SRAM targets #38826

Closed
erwango opened this issue Sep 24, 2021 · 1 comment · Fixed by #38860
Closed

tests/lib/cmsis_dsp: malloc failed on 128K SRAM targets #38826

erwango opened this issue Sep 24, 2021 · 1 comment · Fixed by #38860
Assignees
@stephanosio
Labels
area: CMSIS-DSP area: Tests Issues related to a particular existing or missing test bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@erwango
Copy link
Member

erwango commented Sep 24, 2021

Describe the bug
I'm seeing the following tests failed on targets with 128K RAM:

   tests/lib/cmsis_dsp/matrix/libraries.cmsis_dsp.matrix.binary_f16, nucleo_f207zg
   tests/lib/cmsis_dsp/matrix/libraries.cmsis_dsp.matrix.binary_f16, nucleo_g474re
   tests/lib/cmsis_dsp/matrix/libraries.cmsis_dsp.matrix.binary_f16.fpu, nucleo_g474re

Error message:
Assertion failed at WEST_TOPDIR/zephyr/tests/lib/cmsis_dsp/matrix/src/binary_f16.c:145: test_op2) buffer allocation failed

These tests are run on these targets as min_ram is set to 128, which seems insufficient.
I've been able to reproduce the issue by reducing the available RAM which originally have 192K of RAM (nucleo_f429zi, frdm_k64f)

To Reproduce
twister --ninja -p nucleo_g474re --device-serial /dev/ttyACM0 --device-testing -s tests/lib/cmsis_dsp/matrix/libraries.cmsis_dsp.matrix.binary_f16

Expected behavior
Test should define the adequate min_ram size or should be fixed to consume less RAM.

Impact
Tests failed in CI on 128K RAM targets

Environment (please complete the following information):

  • OS: Linux
  • Toolchain: SDK 0.13.0
  • Commit SHA: v2.7.0-rc2-122-g71934dbc44
@erwango erwango added the bug The issue is a bug, or the PR is fixing a bug label Sep 24, 2021
@erwango erwango added area: CMSIS-DSP area: Tests Issues related to a particular existing or missing test manifest-tensorflow priority: low Low impact/importance bug and removed manifest-tensorflow labels Sep 24, 2021
@erwango
Copy link
Member Author

erwango commented Sep 27, 2021

According to some tests I just did, it seems the min RAM limit for these tests is 141K.
I will update tests requirement to 144.

erwango added a commit to erwango/zephyr that referenced this issue Sep 27, 2021
@erwango
tests/lib/cmsis_dsp: matrix: Limit f16 tc execution on ram => 144
0dab878 
binary_f16 and binary_f16.fpu test cases fail when target
SRAM size is below 140k.
Update test case requirements to set min_ram to 144.

Additionally, remove the platform_exclude hich is now useless
(frdm_kw41z ram is 128k).

Fixes zephyrproject-rtos#38826

Signed-off-by: Erwan Gouriou <erwan.gouriou@linaro.org>
@erwango erwango mentioned this issue Sep 27, 2021
Merged
nashif pushed a commit that referenced this issue Sep 27, 2021
@erwango @nashif
tests/lib/cmsis_dsp: matrix: Limit f16 tc execution on ram => 144
2e4eb78 
binary_f16 and binary_f16.fpu test cases fail when target
SRAM size is below 140k.
Update test case requirements to set min_ram to 144.

Additionally, remove the platform_exclude hich is now useless
(frdm_kw41z ram is 128k).

Fixes #38826

Signed-off-by: Erwan Gouriou <erwan.gouriou@linaro.org>
Rushybrook pushed a commit to Rushybrook/zephyr that referenced this issue Oct 21, 2021
@erwango @Rushybrook
tests/lib/cmsis_dsp: matrix: Limit f16 tc execution on ram => 144
a44aa55 
binary_f16 and binary_f16.fpu test cases fail when target
SRAM size is below 140k.
Update test case requirements to set min_ram to 144.

Additionally, remove the platform_exclude hich is now useless
(frdm_kw41z ram is 128k).

Fixes zephyrproject-rtos#38826

Signed-off-by: Erwan Gouriou <erwan.gouriou@linaro.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephanosio stephanosio

Labels
area: CMSIS-DSP area: Tests Issues related to a particular existing or missing test bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests/lib/cmsis_dsp: matrix: Limit f16 tc execution on ram => 144 erwango/zephyr
2 participants
@stephanosio @erwango