drivers: usb: unify endpoint helper macros #26612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfischer-no
requested review from
galak,
loicpoulain,
MaureenHelm,
nashif and
ydamigos
as code owners
github-actions
bot
added
area: API
loicpoulain
approved these changes
Jul 2, 2020
include/drivers/usb/usb_dc.h
Outdated
| /** Get endpoint address from endpoint index and direction */ | ||
| #define USB_EP_GET_ADDR(idx, dir) ((idx) | ((dir) & USB_EP_DIR_MASK)) | ||
| /** True if the endpoint is an IN endpoint */ | ||
| #define USB_EP_DIR_IS_IN(ep) (USB_EP_GET_DIR(ep) == USB_EP_DIR_IN ? true : false) |
There was a problem hiding this comment.
Why not the simple version:
#define USB_EP_DIR_IS_IN(ep) (USB_EP_GET_DIR(ep) == USB_EP_DIR_IN)
There was a problem hiding this comment.
It turned out this way, I will change it
jfischer-no
force-pushed
the
pr-usb_driver-cleanup
branch
from
990e1dd
to
cf75bdf
Compare
eobalski
suggested changes
Jul 3, 2020
zephyrbot
added
has-conflicts
github-actions
bot
added
area: API
Unify endpoint index and direction helper macros across all usb device drivers. Signed-off-by: Johann Fischer <j.fischer@phytec.de>
ep_idx is common used designator for endpoint index, rename ep_num to ep_idx in usb_dc_sam0 driver. Signed-off-by: Johann Fischer <j.fischer@phytec.de>
jfischer-no
force-pushed
the
pr-usb_driver-cleanup
branch
from
cf75bdf
to
9d434e9
Compare
eobalski
approved these changes
Jul 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unify endpoint index and direction helper macros
across all usb device drivers.
ep_idx is common used designator for endpoint index,
rename ep_num to ep_idx in usb_dc_sam0 driver.