Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: posix: common: k_usleep() synchro just before clock API #28516

Merged
merged 1 commit into from
Sep 19, 2020
Merged

tests: posix: common: k_usleep() synchro just before clock API #28516

merged 1 commit into from
Sep 19, 2020

Conversation

ABOSTM
Copy link
Collaborator

@ABOSTM ABOSTM commented Sep 18, 2020 •
edited
Loading

tests: posix: common: k_usleep() synchro just before clock API

Move printk() out of k_usleep() tick alignment,
for a better tick synchro.

Fixes #25453

@github-actions github-actions bot added the area: Tests Issues related to a particular existing or missing test label Sep 18, 2020
@ABOSTM ABOSTM mentioned this pull request Sep 18, 2020
Closed
andyross
andyross approved these changes Sep 18, 2020
View reviewed changes
Copy link
Contributor

@andyross andyross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW: this test actually had a tick align already, what this is doing is getting the printk() out of the tick-aligned test path. I'd suggest changing the commit message to reflect that.

@ABOSTM
tests: posix: common: move printk() out of k_usleep() tick alignment
96e2af7 
Move printk() out of k_usleep() tick alignment,
for a better tick synchro.

Fixes zephyrproject-rtos#25453

Signed-off-by: Alexandre Bourdiol <alexandre.bourdiol@st.com>
@ABOSTM ABOSTM force-pushed the TEST_POSIX_COMMON_K_USLEEP_SYNCHRO branch from 97cf2df to 96e2af7 Compare September 18, 2020 15:13
@ABOSTM
Copy link
Collaborator Author

ABOSTM commented Sep 18, 2020

FWIW: this test actually had a tick align already, what this is doing is getting the printk() out of the tick-aligned test path. I'd suggest changing the commit message to reflect that.

Commit message updated + PR edit.
Done

@pabigot pabigot self-requested a review September 18, 2020 15:20
@MaureenHelm MaureenHelm added the bug The issue is a bug, or the PR is fixing a bug label Sep 18, 2020
pabigot
pabigot approved these changes Sep 18, 2020
View reviewed changes
Copy link
Collaborator

@pabigot pabigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran this over 250 times with CONFIG_ZTEST_RETEST_IF_PASSED=y so it's probably fine.

@pabigot pabigot mentioned this pull request Sep 18, 2020
Closed
@nashif nashif merged commit 2b44573 into zephyrproject-rtos:master Sep 19, 2020
@ABOSTM ABOSTM mentioned this pull request Sep 21, 2020
Closed
@jenmwms jenmwms mentioned this pull request Apr 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyross andyross andyross approved these changes

@pabigot pabigot pabigot approved these changes

@pfalcon pfalcon Awaiting requested review from pfalcon

Assignees
No one assigned
Labels
area: Tests Issues related to a particular existing or missing test bug The issue is a bug, or the PR is fixing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tests/posix/common fails on nucleo_wb55rg
5 participants
@ABOSTM @andyross @pabigot @nashif @MaureenHelm