-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
serial: introduce CONFIG_UART_USE_RUNTIME_CONFIGURE #35697
Merged
carlescufi
merged 1 commit into
zephyrproject-rtos:main
from
dcpleung:uart_runtime_configure
Jun 7, 2021
Merged
serial: introduce CONFIG_UART_USE_RUNTIME_CONFIGURE #35697
carlescufi
merged 1 commit into
zephyrproject-rtos:main
from
dcpleung:uart_runtime_configure
Jun 7, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwango
reviewed
May 27, 2021
This kconfig option enables runtime configuration of UART controllers. This allows application to call uart_configure() to configure the UART controllers and calling uart_config_get() to retrieve configuration. If this is disabled, UART controllers rely on UART driver's initialization function to properly configure the controller. The main use of this option is mainly code size reduction. Fixes zephyrproject-rtos#16231 Signed-off-by: Daniel Leung <daniel.leung@intel.com>
dcpleung
force-pushed
the
uart_runtime_configure
branch
from
May 27, 2021 14:20
2736c0f
to
960902b
Compare
dcpleung
requested review from
aaillet,
aasthagr,
ABOSTM,
anangl,
bwitherspoon,
dleach02,
FRASTM and
jenmwms
as code owners
May 27, 2021 14:20
dcpleung
requested review from
MaureenHelm,
mbittan,
Mierunski,
mmahadevan108,
nashif,
simonguinot,
ssekar15 and
wjliang
as code owners
May 27, 2021 14:20
FRASTM
approved these changes
May 28, 2021
erwango
approved these changes
May 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this .
Saves ~ 450 bytes of flash per uart instance
zephyrbot
added
platform: ESP32
Espressif ESP32
area: UART
Universal Asynchronous Receiver-Transmitter
platform: nRF
Nordic nRFx
labels
May 28, 2021
zephyrbot
requested review from
ioannisg and
sylvioalves
and removed request for
a user
May 28, 2021 10:47
nashif
approved these changes
May 28, 2021
sylvioalves
approved these changes
May 28, 2021
aaillet
approved these changes
May 31, 2021
anangl
approved these changes
May 31, 2021
Mierunski
approved these changes
May 31, 2021
mmahadevan108
approved these changes
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: UART
Universal Asynchronous Receiver-Transmitter
platform: ESP32
Espressif ESP32
platform: nRF
Nordic nRFx
platform: NXP
NXP
platform: STM32
ST Micro STM32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This kconfig option enables runtime configuration of UART
controllers. This allows application to call uart_configure()
to configure the UART controllers and calling uart_config_get()
to retrieve configuration. If this is disabled, UART controllers
rely on UART driver's initialization function to properly
configure the controller. The main use of this option is mainly
code size reduction.
Fixes #16231
Signed-off-by: Daniel Leung daniel.leung@intel.com