Bluetooth: controller: df: Fixes truncated transmission of CTE #36958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an issue with wrong length of CTE send in connectionless mode, with periodic advertising PDUs. Radio peripheral was not configured to send CTE with correct length while PDU had CTEInfo field informing receiver that CTE is attached to the PDU. Source of the problem was in ll_df_set_cl_cte_tx_enable function. Order of parameters in ull_adv_sync_pdu_alloc was wrong. ULL_ADV_PDU_HDR_FIELD_CTE_INFO was speficed as hdr_rem_fields. Because of that extra_data, memory used to provide CTE configuration to LLL, was not allocated. PDU content is prepared in ULL, so CTEInfo field included correct information, while Radio was never configured by LLL to send CTE. ull_adv_sync_extra_data_set_clear received a pointer to hdr_data, instead of a direct pointer to df_cfg structure. When extra_data was allocated correclty, wrong CTE configuration was provided copied there and LLL received invalid CTE length. It was different than the length in PDUs CTEInfo field. Signed-off-by: Piotr Pryga <piotr.pryga@nordicsemi.no>
ppryga-nordic
requested review from
carlescufi,
cvinayak,
kruithofa and
thoh-ot
as code owners
|
Fixes issue: #36959 |
cvinayak
approved these changes
Jul 14, 2021
Thalley
approved these changes
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36959
There was an issue with wrong length of CTE send in connectionless
mode, with periodic advertising PDUs. Radio peripheral was not
configured to send CTE with correct length while PDU had CTEInfo
field informing receiver that CTE is attached to the PDU.
Source of the problem was in ll_df_set_cl_cte_tx_enable function.
Order of parameters in ull_adv_sync_pdu_alloc was wrong.
ULL_ADV_PDU_HDR_FIELD_CTE_INFO was speficed as hdr_rem_fields.
Because of that extra_data, memory used to provide CTE configuration
to LLL, was not allocated. PDU content is prepared in ULL, so CTEInfo
field included correct information, while Radio was never configured
by LLL to send CTE.
ull_adv_sync_extra_data_set_clear received a pointer to hdr_data,
instead of a direct pointer to df_cfg structure. When extra_data
was allocated correclty, wrong CTE configuration was provided
copied there and LLL received invalid CTE length. It was different
than the length in PDUs CTEInfo field.
Signed-off-by: Piotr Pryga piotr.pryga@nordicsemi.no