twister: Fix execution of twister in makefile environment #37875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hakehuang
reviewed
Aug 24, 2021
benediktibk
force-pushed
the
fix_twister_in_make
branch
from
32e10d1
to
e5a6253
Compare
When run by a makefile twister might fail to decode the text results of commands, based upon the environment settings of the system. With this change escape characters are removed before the string is passed to the json decoder. Signed-off-by: Benedikt Schmidt <benedikt.schmidt@embedded-solutions.at>
benediktibk
force-pushed
the
fix_twister_in_make
branch
from
e5a6253
to
6eed92c
Compare
hakehuang
approved these changes
Aug 26, 2021
hakehuang
approved these changes
Aug 26, 2021
nashif
approved these changes
Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When run by a makefile twister might fail to decode the text results of
commands, based upon the environment settings of the system. With this
change escape characters are removed before the string is passed to the
json decoder.
Signed-off-by: Benedikt Schmidt benedikt.schmidt@embedded-solutions.at