Upgrade crates (tendril, cargo-suity, smartstring, html5ever/xml5ever) #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fantastic. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that running the function
Processor::get_bibliography()led to panics (failed assertion) from the smartstring crate when compiled with newer rustc (at least newer than 1.66).Additionally, compilation with latest rustc indicates a number of crates contain outdated code that will be incompatible with future versions of rustc.
This branch builds on @cormacrelf code in #155 (which upgrades tendril for this same reason) to also upgrade:
Still needing to be updated is nom, but unfortunately upgrading to nom 7 requires some more in-depth surgery and must wait.