Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2D spherical geometry #2927

Open
10 of 14 tasks
zingale opened this issue Jul 24, 2024 · 2 comments
Open
10 of 14 tasks

2D spherical geometry #2927

zingale opened this issue Jul 24, 2024 · 2 comments
Assignees

Comments

@zingale
Copy link
Member

zingale commented Jul 24, 2024

We want to add 2D spherical geometry $(r, \theta)$ on the grid with axisymmetry in $\phi$.

The following tasks need to be done:

@zhichen3 zhichen3 self-assigned this Jul 29, 2024
@zhichen3
Copy link
Collaborator

I think also update mom_flux_has_p and related stuff

zingale pushed a commit that referenced this issue Sep 16, 2024
This is to address issue #2927 . I updated mom_flux_has_p to work with theta direction in 2d spherical. Also update places where it is used. I think it should just work in riemann_solver and HLL_solver, so nothing is changed there. 

For Castro_ctu_hydro.cpp and Castro_mol_hydro.cpp I will need to include ptheta just like pradial, so I'll do that in a separate pr to address that separately. I'll also address trans.cpp separately when I do the transverse flux pr
@zhichen3
Copy link
Collaborator

zhichen3 commented Sep 18, 2024

also need to modify cfl_violation/timestep constraint since in spherical2d dy is just dtheta but we want physical length , so rdtheta, when checking and determining timestep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants