add geometric source terms for 2D spherical geometry #2955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zingale
reviewed
Sep 10, 2024
Source/sources/Castro_geom.cpp
Outdated
| Castro::construct_old_geom_source([[maybe_unused]]MultiFab& source, | ||
| [[maybe_unused]]MultiFab& state_in, | ||
| [[maybe_unused]]Real time, | ||
| [[maybe_unused]]Real dt) |
There was a problem hiding this comment.
I think we decided once that we prefer to use
amrex::ignore_unused(state_in);
to [[maybe_unused]] in the interface
zingale
approved these changes
Sep 10, 2024
|
this looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
This pr adds the geometric source terms of the momentum equation for 2D spherical (R-Theta) coordinate caused by local unit vectors. This is intended to deal with issue #2927
PR motivation
PR checklist
CHANGESfile has been updated, if appropriate