-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nuvoton: Enlarge NuMaker PWM duty cycle range #14379
Conversation
@cyliangtw, thank you for your changes. |
@cyliangtw mbed-os/targets/TARGET_NUVOTON/TARGET_M251/device/StdDriver/src/m251_pwm.c Lines 146 to 149 in 045f443
To: uint32_t PWM_ConfigOutputChannel (PWM_T *pwm, uint32_t u32ChannelNum, uint32_t u32Frequency, uint32_t u32DutyCycle) { return PWM_ConfigOutputChannel2(pwm, u32ChannelNum, u32Frequency, u32DutyCycle*100, 1); } |
@ccli8 , The goal is to increase the resolution of duty from 100 to 10000 to fulfill our demand. Your modification is confused and pwmout_api.c existing implementation already call PWM_ConfigOutputChannel2() directly. More, proprietary BSP m251_pwm.c also suffer the same issue and will follow the same methodology. |
CI started |
Jenkins CI Test : ❌ FAILEDBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
After check Logs & Artifacts of Jenkins CI Test, it's failed in build other vendor's target , such like as K64F or DISCO_L475VG_IOT01A. |
We had internal issue with CI yesterday, its fixed now. CI restarted |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Summary of changes
This PR is to enlarge PWM duty cycle range of NuMaker platforms. The old range is only 0 ~ 100 and can't support higher duty cycle range. In this PR, the range is 0 ~ 10000 and could fulfill MCU usage.
Impact of changes
None
Migration actions required
None
Documentation
None
Pull request type
Test results
Reviewers