fix: Track L1 block for last L2 block body retrieved

[spalladino]

The archiver was keeping a single L1 pointer for L2 blocks, shared by block metadata and block bodies, using the min of the two. However, if a block metadata had no corresponding block body, then the L1 pointer would not be advanced, leading to the same block metadata to being downloaded again, which triggered an error of expected L2 block mismatch.

Having no corresponding block body happens when the tx effects hash is not submitted by the sequencer, which happens when it is detected to have been uploaded already, which happens when the tx effects hash is repeated across two blocks, which happens when two blocks are empty (ie have only padding txs).

By adding separate tracking pointers, we ensure that we don't accidentally process the same block header twice from the archiver. This PR also adds a try/catch to the archiver loop so it doesn't bring down the entire node if it runs into an error.

Fixes #7918

[AztecBot]

Benchmark results

Metrics with a significant change:

• proof_construction_time_sha256_100_ms (16): 5,672 (-23%)
• proof_construction_time_sha256_30_ms (16): 1,408 (-26%)
• protocol_circuit_simulation_time_in_ms (private-kernel-reset-tiny): 499 (+150%)
• protocol_circuit_simulation_time_in_ms (private-kernel-tail): 270 (-61%)
• protocol_circuit_simulation_time_in_ms (private-kernel-tail-to-public): 833 (-73%)
• protocol_circuit_input_size_in_bytes (private-kernel-tail-to-public): 507,554 (-46%)
• protocol_circuit_witness_generation_time_in_ms (private-kernel-init): 399 (-18%)
• protocol_circuit_witness_generation_time_in_ms (private-kernel-inner): 701 (-18%)
• protocol_circuit_witness_generation_time_in_ms (private-kernel-tail-to-public): 708 (-61%)
• protocol_circuit_witness_generation_time_in_ms (private-kernel-tail): 197 (-76%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,805	1,564	695 (-2%)	776 (+2%)	768 (-2%)
proof_construction_time_sha256_30_ms	11,814 (-4%)	3,184 (-6%)	⚠️ 1,408 (-26%)	1,433 (-12%)	1,471 (-7%)
proof_construction_time_sha256_100_ms	44,309 (-1%)	12,448 (-4%)	⚠️ 5,672 (-23%)	5,580 (-11%)	5,496 (-9%)
proof_construction_time_poseidon_hash_ms	79.0	34.0	34.0 (-3%)	59.0	88.0
proof_construction_time_poseidon_hash_30_ms	1,537	420	200 (-1%)	232 (+5%)	270
proof_construction_time_poseidon_hash_100_ms	5,705	1,537 (-1%)	676 (-2%)	742 (+1%)	746

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	4,324	7,844	14,852
l1_rollup_calldata_gas	49,624	92,484	177,500
l1_rollup_execution_gas	1,294,287	2,042,115	3,869,170
l2_block_processing_time_in_ms	251 (+1%)	458 (+3%)	855 (+3%)
l2_block_building_time_in_ms	9,702 (+1%)	18,858 (-1%)	37,614
l2_block_rollup_simulation_time_in_ms	9,702 (+1%)	18,858 (-1%)	37,614
l2_block_public_tx_process_time_in_ms	8,085 (+1%)	16,993 (-1%)	35,693

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	2,979 (+1%)	3,981 (+2%)
node_database_size_in_bytes	12,681,296	16,760,912 (-1%)
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms	proof_size_in_bytes	num_public_inputs	size_in_gates
private-kernel-init	101 (-3%)	⚠️ 399 (-18%)	21,846	44,858	N/A	N/A	N/A	N/A
private-kernel-inner	168 (-2%)	⚠️ 701 (-18%)	72,545	45,005	N/A	N/A	N/A	N/A
private-kernel-reset-tiny	⚠️ 499 (+150%)	1,188 (+15%)	69,614 (+1%)	44,844	N/A	N/A	N/A	N/A
private-kernel-tail	⚠️ 270 (-61%)	⚠️ 197 (-76%)	50,760 (-4%)	52,256	N/A	N/A	N/A	N/A
base-parity	6.11 (+1%)	623 (-1%)	160	96.0	1,123 (-1%)	13,188	19.0	65,536
root-parity	108	129 (+4%)	69,084	96.0	30,432	13,188	19.0	4,194,304
base-rollup	2,985 (-1%)	5,340 (-7%)	187,824	664	97,101 (+3%)	14,020	45.0	16,777,216
root-rollup	96.1	119 (+3%)	54,525	716	27,714 (-4%)	13,988	44.0	4,194,304
public-kernel-setup	90.1 (-3%)	2,840 (+2%)	103,782	71,222	17,331	129,220	3,645	2,097,152
public-kernel-app-logic	106 (-1%)	4,151	103,598	71,222	10,030 (+1%)	129,220	3,645	1,048,576
public-kernel-tail	569 (-1%)	26,714 (-13%)	409,190	16,414	102,351	34,308	679	16,777,216
private-kernel-reset-small	487	N/A	66,533	45,629	N/A	N/A	N/A	N/A
private-kernel-tail-to-public	⚠️ 833 (-73%)	⚠️ 708 (-61%)	⚠️ 507,554 (-46%)	1,697	N/A	N/A	N/A	N/A
public-kernel-teardown	86.1 (-2%)	4,189 (+1%)	104,005	71,222	18,065 (-5%)	129,220	3,645	2,097,152
merge-rollup	60.5 (+1%)	N/A	35,742	664	N/A	N/A	N/A	N/A
undefined	N/A	N/A	N/A	N/A	67,243 (-1%)	N/A	N/A	N/A

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms	proof_size_in_bytes	proving_time_in_ms
ContractClassRegisterer:register	1,344	11,731	341 (-2%)	N/A	N/A
ContractInstanceDeployer:deploy	1,408	11,731	17.9 (-2%)	N/A	N/A
MultiCallEntrypoint:entrypoint	1,920	11,731	476 (-1%)	N/A	N/A
FeeJuice:deploy	1,376	11,731	394 (+2%)	N/A	N/A
SchnorrAccount:constructor	1,312	11,731	176 (-1%)	N/A	N/A
SchnorrAccount:entrypoint	2,304	11,731	530 (-1%)	N/A	N/A
Token:privately_mint_private_note	1,280	11,731	222 (-8%)	N/A	N/A
FPC:fee_entrypoint_public	1,344	11,731	24.0 (+1%)	N/A	N/A
Token:transfer	1,312	11,731	404 (-2%)	N/A	N/A
AuthRegistry:set_authorized (avm)	18,491	N/A	N/A	146,400	2,101 (-2%)
FPC:prepare_fee (avm)	22,958	N/A	N/A	146,464	2,467
Token:transfer_public (avm)	61,614	N/A	N/A	146,464	10,715 (+2%)
AuthRegistry:consume (avm)	41,719	N/A	N/A	146,432	4,991 (+1%)
FPC:pay_refund (avm)	26,227	N/A	N/A	146,432	4,872 (-1%)
Benchmarking:create_note	1,344	11,731	170 (-1%)	N/A	N/A
SchnorrAccount:verify_private_authwit	1,280	11,731	27.3 (-1%)	N/A	N/A
Token:unshield	1,376	11,731	626 (-1%)	N/A	N/A
FPC:fee_entrypoint_private	1,376	11,731	825	N/A	N/A

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
FeeJuice:_increase_public_balance	97.0 (+3%)	8,139
FeeJuice:set_portal	11.1 (+4%)	2,362
Token:constructor	131 (+9%)	31,107
FPC:constructor	94.9 (+1%)	22,380
FeeJuice:mint_public	78.7 (+2%)	6,150
Token:mint_public	82.4	11,720
Token:assert_minter_and_mint	89.9	8,028
AuthRegistry:set_authorized	7.75 (+1%)	4,537
FPC:prepare_fee	274 (+1%)	8,812
Token:transfer_public	44.2 (-1%)	47,374
FPC:pay_refund	61.4 (-6%)	12,114
Benchmarking:increment_balance	1,024 (-1%)	7,450
Token:_increase_public_balance	10.8 (-13%)	8,960
FPC:pay_refund_with_shielded_rebate	138 (+1%)	12,663

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.167 (-2%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	2.18 (+1%)	3.96 (+1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.112	0.111 (+1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	11.5	18.7 (+5%)	31.0	60.2 (-2%)	121 (+4%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.110	0.108 (+5%)	0.100	0.103 (-2%)	0.107 (+3%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	14.3 (-1%)	26.7 (+4%)	44.0	85.5 (+2%)	166 (+1%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.108	0.108 (+4%)	0.106 (+5%)	0.105 (+2%)	0.104 (+1%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	16.7 (+1%)	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	132	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.107 (+1%)	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	64,756	668,997

Transaction size based on fee payment method

| Metric | |
| - | |

[LHerskind]

Looks good to me, the tests have not run and I don't seem to be able to restart them for you.

[github-actions]

Changes to circuit sizes

Generated at commit: 094dd8f8373c49cd24d03fc57fe91ecfd97dd816, compared to commit: 5e25cd688b7a2ce23d693c26ec9d2c1bd7fcb764

🧾 Summary (100% most significant diffs)

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
private_kernel_reset_tiny	+3,712 ❌	+6.43%	+7,366 ❌	+7.50%
private_kernel_reset_small	+4,031 ❌	+6.59%	+9,027 ❌	+7.27%
private_kernel_reset_medium	+4,669 ❌	+6.87%	+12,349 ❌	+7.01%
private_kernel_reset_big	+5,941 ❌	+7.28%	+18,990 ❌	+6.77%
private_kernel_reset	+8,112 ❌	+7.45%	+31,234 ❌	+6.38%
private_kernel_tail_to_public	-35,857 ✅	-48.84%	-62,520 ✅	-52.26%
private_kernel_tail	-9,756 ✅	-66.52%	-33,890 ✅	-73.45%

---

Full diff report 👇

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
private_kernel_reset_tiny	61,458 (+3,712)	+6.43%	105,552 (+7,366)	+7.50%
private_kernel_reset_small	65,189 (+4,031)	+6.59%	133,171 (+9,027)	+7.27%
private_kernel_reset_medium	72,654 (+4,669)	+6.87%	188,588 (+12,349)	+7.01%
private_kernel_reset_big	87,579 (+5,941)	+7.28%	299,626 (+18,990)	+6.77%
private_kernel_reset	117,054 (+8,112)	+7.45%	520,662 (+31,234)	+6.38%
private_kernel_tail_to_public	37,562 (-35,857)	-48.84%	57,120 (-62,520)	-52.26%
private_kernel_tail	4,910 (-9,756)	-66.52%	12,253 (-33,890)	-73.45%