refactor: simplify registry

[LHerskind]

Fixes #7937.

[LHerskind]

• refactor: proper portal setup for fees + test #7944
• refactor: simplify registry #7939 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @LHerskind and the rest of your teammates on Graphite

[github-actions]

Changes to circuit sizes

Generated at commit: 0420459c30b767e0013ab3a819f2317173082b04, compared to commit: fb574aaf70dc98bb006b1f649a77b0c14b87d60e

🧾 Summary (100% most significant diffs)

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
public_kernel_tail	-1,184 ✅	-0.12%	-4,358 ✅	-0.05%
rollup_base	-1,215 ✅	-0.35%	-4,389 ✅	-0.05%
public_kernel_teardown	-1,062 ✅	-0.36%	-4,236 ✅	-0.22%
public_kernel_setup	-1,062 ✅	-0.49%	-4,236 ✅	-0.23%
parity_root	-4,656 ✅	-92.56%	-17,697 ✅	-0.34%
rollup_root	-3,593 ✅	-82.85%	-13,460 ✅	-0.34%
rollup_merge	-2,533 ✅	-88.81%	-9,226 ✅	-0.35%
private_kernel_empty	-1,471 ✅	-68.71%	-5,050 ✅	-55.02%

---

Full diff report 👇

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
public_kernel_tail	1,005,149 (-1,184)	-0.12%	9,385,243 (-4,358)	-0.05%
rollup_base	348,208 (-1,215)	-0.35%	9,076,523 (-4,389)	-0.05%
public_kernel_teardown	295,080 (-1,062)	-0.36%	1,914,718 (-4,236)	-0.22%
public_kernel_setup	215,977 (-1,062)	-0.49%	1,833,974 (-4,236)	-0.23%
parity_root	374 (-4,656)	-92.56%	5,207,941 (-17,697)	-0.34%
rollup_root	744 (-3,593)	-82.85%	3,951,135 (-13,460)	-0.34%
rollup_merge	319 (-2,533)	-88.81%	2,609,046 (-9,226)	-0.35%
private_kernel_empty	670 (-1,471)	-68.71%	4,129 (-5,050)	-55.02%

[AztecBot]

Docs Preview

Hey there! 👋 You can check your preview at https://66bb8ad756246168d7af0412--aztec-docs-dev.netlify.app

[AztecBot]

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,767	1,553 (-1%)	702 (-1%)	766 (-3%)	766 (-4%)
proof_construction_time_sha256_30_ms	11,866 (-1%)	3,169 (-1%)	1,409	1,445	1,478
proof_construction_time_sha256_100_ms	44,241 (-4%)	12,336 (+1%)	5,692 (+1%)	5,607	5,534 (+1%)
proof_construction_time_poseidon_hash_ms	78.0	34.0	44.0 (+29%)	65.0 (+12%)	91.0 (+5%)
proof_construction_time_poseidon_hash_30_ms	1,528	418 (-1%)	201 (-1%)	224 (-3%)	266 (-3%)
proof_construction_time_poseidon_hash_100_ms	5,653	1,529	679 (-2%)	728 (-2%)	754 (-2%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	4,324	7,844	14,852
l1_rollup_calldata_gas	49,624	92,476	177,536
l1_rollup_execution_gas	1,294,287	2,042,107	3,869,206
l2_block_processing_time_in_ms	252 (+2%)	453 (+2%)	842 (+2%)
l2_block_building_time_in_ms	9,332 (-1%)	18,177	36,164 (-1%)
l2_block_rollup_simulation_time_in_ms	9,332 (-1%)	18,177	36,163 (-1%)
l2_block_public_tx_process_time_in_ms	7,878 (-1%)	16,623	34,590

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	2,998 (+1%)	3,926
node_database_size_in_bytes	12,730,448	16,887,888
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms
private-kernel-init	101 (+5%)	392 (-1%)	21,846	44,858	N/A
private-kernel-inner	168 (-4%)	705 (+1%)	72,545	45,005	N/A
private-kernel-reset-tiny	508 (+1%)	1,186 (-2%)	69,614	44,844	N/A
private-kernel-tail	270	194 (-1%)	50,760	52,256	N/A
base-parity	5.52	N/A	160	96.0	N/A
root-parity	33.2	N/A	69,084	96.0	N/A
base-rollup	2,861	N/A	187,817	664	N/A
root-rollup	38.5	N/A	54,525	716	N/A
public-kernel-setup	99.7 (+1%)	N/A	103,760	71,222	N/A
public-kernel-app-logic	106	N/A	103,599	71,222	N/A
public-kernel-tail	571	N/A	409,190	16,414	N/A
private-kernel-reset-small	502 (+3%)	N/A	66,533	45,629	N/A
private-kernel-tail-to-public	1,485 (+10%)	704	507,554	1,697	N/A
public-kernel-teardown	94.8 (+1%)	N/A	104,005	71,222	N/A
merge-rollup	19.0 (-1%)	N/A	35,742	664	N/A
undefined	N/A	N/A	N/A	N/A	67,757 (-3%)

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms
ContractClassRegisterer:register	1,344	11,731	344
ContractInstanceDeployer:deploy	1,408	11,731	18.2
MultiCallEntrypoint:entrypoint	1,920	11,731	457 (-1%)
FeeJuice:deploy	1,376	11,731	395 (+3%)
SchnorrAccount:constructor	1,312	11,731	168 (-1%)
SchnorrAccount:entrypoint	2,304	11,731	505
Token:privately_mint_private_note	1,280	11,731	210 (-2%)
FPC:fee_entrypoint_public	1,344	11,731	20.8 (-16%)
Token:transfer	1,312	11,731	403
Benchmarking:create_note	1,344	11,731	164
SchnorrAccount:verify_private_authwit	1,280	11,731	27.5 (+1%)
Token:unshield	1,376	11,731	636 (+1%)
FPC:fee_entrypoint_private	1,376	11,731	859 (+2%)

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
FeeJuice:_increase_public_balance	53.8 (+1%)	8,139
FeeJuice:set_portal	10.1 (-19%)	2,362
Token:constructor	83.0 (-2%)	31,107
FPC:constructor	53.6 (+2%)	22,380
FeeJuice:mint_public	37.4	6,150
Token:mint_public	42.2 (-1%)	11,720
Token:assert_minter_and_mint	72.4 (+9%)	8,028
AuthRegistry:set_authorized	44.6 (+25%)	4,537
FPC:prepare_fee	238 (-4%)	8,812
Token:transfer_public	24.3 (-27%)	47,374
FPC:pay_refund	55.8 (-5%)	12,114
Benchmarking:increment_balance	972 (-1%)	7,450
Token:_increase_public_balance	39.2 (+2%)	8,960
FPC:pay_refund_with_shielded_rebate	68.5 (+3%)	12,663

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.161 (-1%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	2.17	3.80 (-2%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.112	0.107 (-2%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	11.4	18.1 (+1%)	31.6 (+1%)	60.2 (+1%)	116 (+3%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.109	0.105 (+1%)	0.103	0.103 (+2%)	0.104 (+3%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	14.2	26.2 (-2%)	44.8 (+4%)	83.8 (+1%)	166 (+2%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.108	0.105 (-2%)	0.108 (+3%)	0.103 (+1%)	0.105 (+2%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	16.5 (+1%)	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	132	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.106 (+1%)	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	64,779	668,997

Transaction size based on fee payment method

| Metric | |
| - | |

[Maddiaa0]

is it worth keeping these assertions in the test, but just calling the INBOX() on the new rollup?

[LHerskind]

Think it make more sense to do related to #7959 then.

[Maddiaa0]

hmm, this adds the gas cost of another external call? will we end up going back on this change / adding a method to the registry anyway when golfing?

[LHerskind]

It needs to be fixed as part of #7959.