fix: make simulations validate resulting tx by default

[sklppy88]

Closes #7956.

This PR simply flips a switch to make all simulations fail by default if the transaction is an invalid one. Previously it did not throw due to wanting to minimize disruptions in the PR, but it seems like there were not that many effects. The only exception is the e2e prover. These are failing due to a prover verification, and I have made an issue for this to be looked into.

[sklppy88]

• fix: make simulations validate resulting tx by default #8157 👈
• fix: enforce parity of sequencer tx validation and node tx validation #7951 : 2 other dependent PRs (#7841 , #8220 )
• fix: lay plumbing for having simulations throw an error if they cannot be added in a block #7839 : 1 other dependent PR (#7840 )
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sklppy88 and the rest of your teammates on Graphite

[AztecBot]

Benchmark results

Metrics with a significant change:

• protocol_circuit_simulation_time_in_ms (private-kernel-tail-to-public): 1,396 (+109%)
• avm_simulation_time_ms (Token:mint_public): 320 (+533%)
• avm_simulation_time_ms (Token:assert_minter_and_mint): 42.7 (-87%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,743	1,563	714	762	775
proof_construction_time_sha256_30_ms	11,491	3,088	1,379 (-1%)	1,429 (-1%)	1,457
proof_construction_time_sha256_100_ms	44,096	11,922	5,510 (+1%)	5,485 (-1%)	5,719
proof_construction_time_poseidon_hash_ms	79.0 (+1%)	34.0	34.0	57.0	88.0
proof_construction_time_poseidon_hash_30_ms	1,527	423	203	243 (+6%)	265 (-1%)
proof_construction_time_poseidon_hash_100_ms	5,638	1,513	677	735 (-1%)	748 (+1%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	4,356	7,876	14,884
l1_rollup_calldata_gas	50,220	92,942	178,144
l1_rollup_execution_gas	845,554	1,579,172	3,364,430
l2_block_processing_time_in_ms	243 (-4%)	445 (+1%)	804
l2_block_building_time_in_ms	11,554 (+2%)	22,419	45,630 (+3%)
l2_block_rollup_simulation_time_in_ms	11,554 (+2%)	22,419	45,629 (+3%)
l2_block_public_tx_process_time_in_ms	9,839 (+2%)	20,712	43,852 (+3%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	2,953 (-2%)	3,918 (+2%)
node_database_size_in_bytes	12,607,568	16,662,608 (-1%)
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms
private-kernel-init	96.2 (+4%)	397 (-1%)	21,735	44,860	N/A
private-kernel-inner	175 (-2%)	702	72,544	45,007	N/A
private-kernel-reset-tiny	309 (-2%)	715	65,593	44,846	N/A
private-kernel-tail	167	139 (+2%)	50,644	52,257	N/A
base-parity	5.60 (-1%)	N/A	160	96.0	N/A
root-parity	35.3	N/A	73,948	96.0	N/A
base-rollup	2,972 (+1%)	N/A	189,136	664	N/A
block-root-rollup	41.6	N/A	58,205	2,448	N/A
public-kernel-setup	84.8	N/A	105,085	71,222	N/A
public-kernel-app-logic	98.3 (+1%)	N/A	104,911	71,222	N/A
public-kernel-tail	865	N/A	390,582	16,414	N/A
private-kernel-reset-small	315 (+1%)	N/A	66,341	45,629	N/A
private-kernel-tail-to-public	⚠️ 1,396 (+109%)	614	455,400	1,825	N/A
public-kernel-teardown	84.1	N/A	105,349	71,222	N/A
merge-rollup	20.4 (+3%)	N/A	38,174	664	N/A
undefined	N/A	N/A	N/A	N/A	79,291

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms
ContractClassRegisterer:register	1,344	11,731	342 (-1%)
ContractInstanceDeployer:deploy	1,408	11,731	18.3
MultiCallEntrypoint:entrypoint	1,920	11,731	404
FeeJuice:deploy	1,376	11,731	389
SchnorrAccount:constructor	1,312	11,731	73.3
SchnorrAccount:entrypoint	2,336	11,731	394
Token:privately_mint_private_note	1,280	11,731	100 (-3%)
FPC:fee_entrypoint_public	1,344	11,731	27.2 (-3%)
Token:transfer	1,312	11,731	226 (-2%)
Benchmarking:create_note	1,344	11,731	87.7
SchnorrAccount:verify_private_authwit	1,280	11,731	27.8 (+1%)
Token:unshield	1,376	11,731	522 (+1%)
FPC:fee_entrypoint_private	1,376	11,731	693

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
FeeJuice:_increase_public_balance	57.1 (-1%)	8,174
FeeJuice:set_portal	11.1 (-7%)	4,055
Token:constructor	82.3 (-1%)	29,082
FPC:constructor	55.0 (-2%)	18,940
FeeJuice:mint_public	41.0	6,522
Token:mint_public	⚠️ 320 (+533%)	12,704
Token:assert_minter_and_mint	⚠️ 42.7 (-87%)	8,467
AuthRegistry:set_authorized	38.2 (-22%)	4,194
FPC:prepare_fee	235 (-2%)	6,747
Token:transfer_public	27.4 (+21%)	39,863
FPC:pay_refund	59.0 (-11%)	9,398
Benchmarking:increment_balance	1,226	7,263
Token:_increase_public_balance	43.8 (+5%)	8,686
FPC:pay_refund_with_shielded_rebate	65.5 (+6%)	9,881

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.156 (-2%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	2.17 (-1%)	3.94 (+1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.113 (-1%)	0.111 (+2%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	11.3 (+1%)	18.8 (+8%)	30.9 (+1%)	62.6 (+7%)	114 (+2%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.108 (+1%)	0.109 (+8%)	0.101 (+1%)	0.107 (+6%)	0.101
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	14.9 (+3%)	25.8 (+2%)	43.3	84.3 (+3%)	162 (+1%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.114 (+3%)	0.104 (+1%)	0.105 (-1%)	0.104 (+3%)	0.102 (-1%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	16.7 (+1%)	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	132	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.107 (+1%)	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	64,779	668,997

Transaction size based on fee payment method

| Metric | |
| - | |

[sklppy88]

This had to be added here to allow for the param to be passed down into the wallet. It was already done on the non-batch call.

[alexghr]

lgtm 👍