Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA actions #285

Merged
merged 1 commit into from
Oct 5, 2023
Merged

QA actions #285

merged 1 commit into from
Oct 5, 2023

Conversation

halungge
Copy link
Contributor

@halungge halungge commented Oct 4, 2023

  • add cscs-ci run to test reminder script
  • combine QA runs for tools and model in the same action
  • trigger QA action on pull_request [open,reopened, synchronize]

trigger QA for tools and model in the same action
trigger QA run on pull_request [open,reopened, synchronize]
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Mandatory Tests

Please make sure you run these tests via comment before you merge!

  • cscs-ci run
  • launch jenkins spack

Optional Tests

In case your change might affect downstream icon-exclaim, please consider running

  • launch jenkins icon

For more detailed information please look at CI in the EXCLAIM universe.

@halungge
Copy link
Contributor Author

halungge commented Oct 4, 2023

cscs-ci run

@halungge
Copy link
Contributor Author

halungge commented Oct 4, 2023

launch jenkins spack

1 similar comment
@halungge
Copy link
Contributor Author

halungge commented Oct 4, 2023

launch jenkins spack

Copy link
Contributor

@samkellerhals samkellerhals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@halungge halungge merged commit 6ff0dc0 into main Oct 5, 2023
5 checks passed
- "tools/**"
types: [submitted]

types: [opened, reopened, synchronize]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to trigger on all changes? Then just removing types completely should do it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah didn't see that it was already merged...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants