Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA actions #285

Merged
merged 1 commit into from
Oct 5, 2023
Merged

QA actions #285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 4 additions & 12 deletions .github/workflows/icon4py-qa.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,21 +5,10 @@ on:
push:
branches:
- main
paths-ignore:
- "tools/**"
pull_request:
branches:
- main
paths-ignore:
- "tools/**"
types: [opened, reopened, assigned, ready_for_review]
pull_request_review:
branches:
- main
paths-ignore:
- "tools/**"
types: [submitted]

types: [opened, reopened, synchronize]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to trigger on all changes? Then just removing types completely should do it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah didn't see that it was already merged...

jobs:
pre-commit-icon4py-model:
runs-on: ubuntu-latest
Expand All @@ -46,6 +35,9 @@ jobs:
python -m pip install --upgrade pip setuptools wheel
python -m pip install -r ./requirements-dev.txt
python -m pip list
- name: Run checks in icon4pytools
run: |
pre-commit run --config tools/.pre-commit-config.yaml --all-files
- name: Run checks icon4py-model-common
run: |
pre-commit run --config model/common/.pre-commit-config.yaml --all-files
Expand Down
57 changes: 0 additions & 57 deletions .github/workflows/icon4pytools-qa.yml
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion .github/workflows/mandatory_and_optional_test_reminder.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:

Please make sure you run these tests via comment before you merge!


* `cscs-ci run`
* `launch jenkins spack`

**Optional Tests**
Expand Down