-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AppVevor build for Windows support #409
Comments
CI on Windows would be a nice to have. I would not call it essential, as most parts of the code stay far away from the APIs where the differences matter, but some Linux based assumptions are broken on windows, and we might catch a few of those. The setup doesn't run as smooth as it does on Linux, due to missing prebuilt dependencies. |
Hmmmm, sounds tricky. Well, you might be the person for this @schlenk! Otherwise, I'll give it a stab when I get some time. |
I tried this and I ran into the issue with pyldap. I don't like the idea f having some other library in the repository just because we need it to build on windows. |
That's great @tpazderka - I think that would be fine, no? If it is clear, and separated in some way. The benefit of having this aspect of the CI would definitely help us catch issues on Windows easier. Can you share the build and error you were seeing? |
It can be seen here. I don't particularly like it since it adds some extra stuff to the repo that is not needed. Although we can probably exclude it from setup and such I would rather try a different way. |
I think it would be fine if we could isolate the ldap needing tests, and skip them for windows. After all, thats not the main usecase and for many cases the pyldap dependency is strictly optional. There simply is no Windows whl for pyldap on pypi, but there are .whl's found here: https://www.lfd.uci.edu/~gohlke/pythonlibs/ but those pages are deliberately styled so you cannot simply use them to install directly with PIP. So one way would be to use requests to just download a pyldap.whl from there, cache it locally and have pip use the whl from a local directoy. |
Well those pages have obfuscated download links so the download might be real pain. I do like the idea of pyldap being an optional dependency and marking that as I will try to focus on that. |
Close #409 FIXME: Update image build URL after authorization
* Add build support for appveyor Close CZ-NIC#409
https://www.appveyor.com/
We should probably do that. I see a number of issues reported on the windows platform.
This CI build might smoke out anything stupid we might do :)
The text was updated successfully, but these errors were encountered: