Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark ldap as optional dependency #457

Closed
tpazderka opened this issue Dec 11, 2017 · 0 comments
Closed

Mark ldap as optional dependency #457

tpazderka opened this issue Dec 11, 2017 · 0 comments
Assignees
@tpazderka
Labels
enhancement

Comments

@tpazderka
Copy link
Collaborator

Brought up in #409...

ldap can be marked as an optional dependency in setup.py. The imports should be surrounded by try and throw ImproperlyConfigured if ldap is not installed.

Test requiring ldap should be skipped if ldap is not installed.
@tpazderka tpazderka self-assigned this Dec 11, 2017
tpazderka added a commit that referenced this issue Dec 12, 2017
@tpazderka
Mark pyldap as optional
caaf6dd 
Close #457
@tpazderka tpazderka mentioned this issue Dec 12, 2017
Merged
2 tasks
tpazderka added a commit that referenced this issue Dec 12, 2017
@tpazderka
Mark pyldap as optional
998c0cc 
Close #457
tpazderka added a commit that referenced this issue Dec 12, 2017
@tpazderka
Mark pyldap as optional
41a51f7 
Close #457
andrewkrug pushed a commit to mozilla-iam/pyoidc that referenced this issue Jun 6, 2019
@tpazderka @andrewkrug
Mark pyldap as optional
de75583 
Close CZ-NIC#457
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tpazderka tpazderka

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tpazderka