to_jwe/from_jwe fix #374
Merged
to_jwe/from_jwe fix #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually pyjwkest 1.3.4 is better :-) |
|
Not really sure why Tarvis fails. Works on my machine. |
If you're relying on the new pyjwktest, it's being installed from the requirements file on the Travis build. Try running a |
|
Damn, OK got it. |
|
OK, so the problem was with pyjwkest. Fixed that now. |
decentral1se
reviewed
Jun 9, 2017
|
|
||
|
|
||
| def test_to_jwt_rsa(): | ||
| msg = Message(a='foo', b='bar', c='tjoho') |
There was a problem hiding this comment.
This can be a fixture that goes in conftest.py.
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to this library! Please include the following check
list in your pull request submission (you can delete this message). If your
changes don't need a change log or documentation update, please ignore this.
CHANGELOG.md.to_jwe/from_jwe using elleptic curve crypto is dependent on pyjwkest to be of version 1.3.3 or later to work.