Make sure the issuer of the ID Token is the correct one. #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis fails because #374 isn't accepted yet. Wrong of me, I was one step off :-/ |
schlenk
reviewed
Jun 9, 2017
src/oic/oic/message.py
Outdated
| @@ -674,6 +675,13 @@ class IdToken(OpenIDSchema): | |||
| def verify(self, **kwargs): | |||
| super(IdToken, self).verify(**kwargs) | |||
|
|
|||
| try: | |||
| kwargs['iss'] == self['iss'] | |||
There was a problem hiding this comment.
Why should this produce an AssertionError? no assert anywhere...
It is also not a great idea to use 'assert' for this kind of code, as 'assert' gets removed when someone runs python with optimization (-O), so logic fails.
So maybe just raise IssuerMismatch directly if the comparision fails.
There was a problem hiding this comment.
Correct, I should have know better.
1 similar comment
2 similar comments
|
🍺 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should not accept an ID Token from anyone but the expected one.