Improved Terrain Shadows #3765
Merged
Improved Terrain Shadows #3765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Looks promising, you'll have to walk @bagnell and I through all the parameters tomorrow. |
lilleyse
force-pushed
the
shadows-terrain-aliasing
branch
from
434d08d
to
da99091
Compare
lilleyse
force-pushed
the
shadows-terrain-aliasing
branch
from
da99091
to
fddd9d1
Compare
conditionally compiled.
…fading for overhead views
Shadow map shaders
|
@bagnell If the most recent changes look ok to you, we should merge this branch into |
lilleyse
force-pushed
the
shadows-terrain-aliasing
branch
from
0ce76eb
to
40355e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #2594
Not quite ready for a code review since the code needs some cleanup, but I'm getting some better results now. The shadow parameters for terrain are really different than for the models I've been testing with. One thing that helps now is offsetting the shadow position based on its normal when the face is parallel with the light direction. There are still some artifacts that are more noticeable when moving the camera, for example when different terrain LOD's start to load in.
I added a lot more UI buttons for fine tweaking of shadow parameters.