Fix promises for 3D Tiles #4200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.batchTableResources = undefined; | ||
| this.featurePropertiesDirty = false; | ||
|
|
||
| this._contentReadyToProcessPromise = when.defer(); | ||
| this._readyPromise = when.defer(); |
There was a problem hiding this comment.
Up to you, but I would recommend changing _readyPromise to _readyDeferred and contentReadyToProcessPromise to contentReadyToProcessDeferred throughout this PR to avoid confusion in the future and make it clear that these are deferreds and not promises.
There was a problem hiding this comment.
I kept it that way because it's a common theme, Model and Primitive for example have that naming too.
There was a problem hiding this comment.
OK, we can always revisit it in a separate PR; probably when we do the big when -> bluebird switchover.
|
That's my only comment, like I said, it's up to you. Everything else looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #4142 for all the 3D Tiles related classes.
A solution for #3453 will be in a separate PR.