Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed reversing non alphabetic characters on RTL labels #7517

Merged
merged 4 commits into from
Feb 19, 2019

Conversation

hodbauer
Copy link
Contributor

fixing issue #7501

@cesium-concierge
Copy link

Thanks for the pull request @hodbauer!

  • ✔️ Signed CLA found.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@hodbauer
Copy link
Contributor Author

hodbauer commented Feb 3, 2019

@pjcozzi, how could I add a reviewer to this pr?

@hpinkos
Copy link
Contributor

hpinkos commented Feb 4, 2019

Thanks for opening the pull request @hodbauer!

@mramato can you review this?

@hodbauer
Copy link
Contributor Author

hodbauer commented Feb 7, 2019

amm @hpinkos , how could I remove all the mess that I done about the last push?

@hpinkos
Copy link
Contributor

hpinkos commented Feb 8, 2019

@hodbauer I was able to fix it by merging in master again.

git checkout master
git remote add public-cesium https://github.com/AnalyticalGraphicsInc/cesium.git
git fetch public-cesium
git merge --ff-only public-cesium/master
git checkout fix-rtl-label
git merge master
git remote rm public-cesium
git push

@hodbauer
Copy link
Contributor Author

@hpinkos any news?

@hpinkos
Copy link
Contributor

hpinkos commented Feb 19, 2019

Sorry for the delay on this! Everything looks good. Thanks for the fix =)

@hpinkos hpinkos merged commit 0695104 into CesiumGS:master Feb 19, 2019
@hpinkos hpinkos mentioned this pull request Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants