Added support for large Rectangles in OrientedBoundingBox.fromRectangle

[IanLilleyT]

There have been reports of 3D tiles that use TileBoundingRegion disappearing when viewing from a horizon angle. This is because the root tile generates a broken OrientedBoundingBox when the Rectangle's width is greater than half the ellipsoid. The terrain system doesn't have this problem because it handles this edge case and generates a BoundingSphere instead.

In this PR OrientedBoundingBox.fromRectangle has been made to work with larger rectangles. The approach is different than small rectangles which orient the OBB around the rectangle's center normal. I tried doing it this way for large rectangles but it produced very poorly fitted, albeit correct OBBs. The final approach ignores the latitude when calculating the OBBs orientation.

With this fix, all of the special case code is gone. I did a good amount of testing but this change impacts a lot of core systems so more eyes on it the better.

Fixes #4483

Sandcastle

Examples:

3D tile before (incorrectly culled):

3D tile after:

@loshjawrence
@lilleyse
@jasonbeverage

[cesium-concierge]

Thanks for the pull request @IanLilleyT!

• ✔️ Signed CLA found.
• ❔ CHANGES.md was not updated.
  • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

• Cesium Viewer works.
• Works in 2D/CV.
• Works (or fails gracefully) in IE11.

[jasonbeverage]

Very cool, this will help tremendously with global datasets!

[hpinkos]

@IanLilleyT could this fix #4483?

[IanLilleyT]

@hpinkos Just tested and it does not fix it, but I'm looking into it

[IanLilleyT]

@hpinkos Looks like GroundPrimitive swapped the order of the minimumHeight and maximumHeight parameters to OrientedBoundingBox.fromRectangle. My newest commit fixes it.

Sandcastle from #4483

[hpinkos]

GroundPrimitive swapped the order of the minimumHeight and maximumHeight parameters

🤦‍♀️

Nice catch @IanLilleyT 😆

[IanLilleyT]

@lilleyse fixed some bugs, ready for review

[lilleyse]

Looks good based on my checks

• The number of render tiles is the same between this branch and master. I tested all the different terrain providers and 3D Tiles.
• The OBBs look good with rectangles spanning from positive longitude to negative longitude (crossing IDL)
• Confirmed that the Alaska tileset above and another tileset that had this problem are now working in 3D.

The only thing to fix now is there's a crash when switching to 2D or CV with the Alasaka tileset.

[hpinkos]

@lilleyse did you check rectangles at the poles?

[lilleyse]

@hpinkos yes I forgot to mention that, I checked as many extreme cases as I could in the Sandcastle example including poles.

This is how I ended up hitting this bug, which also happens in master: #8478

[IanLilleyT]

@lilleyse That crash you posted is a different problem which is fixed here: #8482

[lilleyse]

@IanLilleyT cool, I'll check that out next