CU-8692kn0yv Fix issue with fake dict in identifier based config #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e specifically the get method which was not able to return default values for non-existant keys
S2P2
added a commit
to S2P2/MedCAT
that referenced
this pull request
Aug 29, 2023
mart-r
added a commit
that referenced
this pull request
Sep 21, 2023
* remove bad merge <p> element * CU-8692kpchc Fix for Rosalind link not working (#342) * CU-8692kpchc Add the 403 exception to vocab downloader * CU-8692kpchc Add the new vocab download link * Add missing self argument (#343) To `_refset_df2dict ` method in Snomed preprocessing * CU-8692kn0yv Fix issue with fake dict in identifier based config More specifically the get method which was not able to return default values for non-existant keys (#341) * CU-8692mevx8 Fix issue with filters not taking effect in train_supervised method (#345) * CU-8692mevx8 Fix issue with filters not taking effect in train_supervised method * CU-8692mevx8 Fix filter retention in train_supervised method --------- Co-authored-by: tomolopolis <tsearle88@gmail.com>
mart-r
added a commit
to mart-r/MedCAT
that referenced
this pull request
Sep 21, 2023
More specifically the get method which was not able to return default values for non-existant keys (CogStack#341)
mart-r
added a commit
that referenced
this pull request
Sep 21, 2023
More specifically the get method which was not able to return default values for non-existant keys (#341)
mart-r
added a commit
that referenced
this pull request
Sep 21, 2023
* CU-8692kn0yv Fix issue with fake dict in identifier based config More specifically the get method which was not able to return default values for non-existant keys (#341) * Bump run target to Ubuntu 20.04 since 18.04 targets do not exist anymore * Bump main worfklow target to 20.04 as well
mart-r
added a commit
to mart-r/MedCAT
that referenced
this pull request
Sep 21, 2023
More specifically the get method which was not able to return default values for non-existant keys (CogStack#341)
mart-r
added a commit
that referenced
this pull request
Sep 22, 2023
More specifically the get method which was not able to return default values for non-existant keys (#341)
mart-r
added a commit
that referenced
this pull request
Sep 22, 2023
More specifically the get method which was not able to return default values for non-existant keys (#341)
mart-r
added a commit
that referenced
this pull request
Oct 12, 2023
More specifically the get method which was not able to return default values for non-existant keys (#341)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More specifically the get method which was not able to return default values for non-existant keys.
This PR will make sure the
__getitem__method ofFakeDictwill raise a KeyError as would be expected for a dict instead of an AttributionError (which was the case up until now).This will ensure that the
FakeDict.getmethod will catch the correct exception in theexceptclause.Issue raised here:
https://discourse.cogstack.org/t/attribute-error-for-medcat-trainer/234