CU-8692mevx8 Fix issue with filters not taking effect in train_supervised method #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomolopolis
approved these changes
Sep 21, 2023
I don't think so. This should make it behave like it was supposed to to begin with. |
mart-r
added a commit
that referenced
this pull request
Sep 21, 2023
* remove bad merge <p> element * CU-8692kpchc Fix for Rosalind link not working (#342) * CU-8692kpchc Add the 403 exception to vocab downloader * CU-8692kpchc Add the new vocab download link * Add missing self argument (#343) To `_refset_df2dict ` method in Snomed preprocessing * CU-8692kn0yv Fix issue with fake dict in identifier based config More specifically the get method which was not able to return default values for non-existant keys (#341) * CU-8692mevx8 Fix issue with filters not taking effect in train_supervised method (#345) * CU-8692mevx8 Fix issue with filters not taking effect in train_supervised method * CU-8692mevx8 Fix filter retention in train_supervised method --------- Co-authored-by: tomolopolis <tsearle88@gmail.com>
mart-r
added a commit
to mart-r/MedCAT
that referenced
this pull request
Sep 21, 2023
…ised method (CogStack#345) * CU-8692mevx8 Fix issue with filters not taking effect in train_supervised method * CU-8692mevx8 Fix filter retention in train_supervised method
mart-r
added a commit
that referenced
this pull request
Sep 22, 2023
…ised method (#345) * CU-8692mevx8 Fix issue with filters not taking effect in train_supervised method * CU-8692mevx8 Fix filter retention in train_supervised method
mart-r
added a commit
that referenced
this pull request
Sep 22, 2023
…ised method (#345) * CU-8692mevx8 Fix issue with filters not taking effect in train_supervised method * CU-8692mevx8 Fix filter retention in train_supervised method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still a WIP.
But I identified an issue.
So it looks like when I made the change in #274 I had misunderstood the reason for the copying of the linking filters and "solved" it in a way that made the local filters not available for the vector context model or context based linker.
So effectively, the per-project filters and the extra CUI filters weren't taken into account at all.
So this PR will fix that.
With that said, there may be other issues in there. So I'd say this is still a WIP.
PS:
If someone wants to try this, they can install
medcatbased on this branch:Or to try and add it to an older version you can cherry-pick the change:
Or you can apply the patch